-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Add CI and Task for formatting R and Rust code #73
Draft
etiennebacher
wants to merge
14
commits into
eitsupi:main
Choose a base branch
from
etiennebacher:setup-fmt-ci
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
1f28127
init
etiennebacher a310152
add air.toml
etiennebacher 7c99e5e
add task
etiennebacher fc65155
more options in air.toml
etiennebacher 261a141
do not --check in task
etiennebacher 71584e7
init
etiennebacher dd39a97
add air.toml
etiennebacher c504148
add task
etiennebacher 1fd7b95
more options in air.toml
etiennebacher fa2bbd7
do not --check in task
etiennebacher 449ec7a
Merge branch 'setup-fmt-ci' of https://github.com/etiennebacher/neo-r…
etiennebacher df4d474
Merge branch 'main' into setup-fmt-ci
etiennebacher a27c4f3
exclude 000-wrappers.R [skip ci]
etiennebacher e970ba9
Merge branch 'main' into setup-fmt-ci
etiennebacher File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
name: format | ||
|
||
on: | ||
push: | ||
branches: [main, master] | ||
pull_request: | ||
branches: [main, master] | ||
|
||
concurrency: | ||
group: ${{ github.workflow }}-${{ github.head_ref }} | ||
cancel-in-progress: true | ||
|
||
jobs: | ||
ci: | ||
runs-on: ubuntu-latest | ||
|
||
steps: | ||
- uses: actions/checkout@v4 | ||
|
||
- name: Set up Rust | ||
run: rustup component add rustfmt | ||
|
||
- name: Install `air` | ||
run: curl -LsSf https://github.com/posit-dev/air/releases/latest/download/air-installer.sh | sh | ||
|
||
- name: Check formatting in R | ||
run: air format . --check | ||
|
||
- name: Check formatting in Rust | ||
run: cargo fmt --all --check --manifest-path src/rust/Cargo.toml |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
[format] | ||
line-width = 80 | ||
indent-width = 2 | ||
indent-style = "space" | ||
line-ending = "auto" | ||
persistent-line-breaks = true | ||
exclude = ["R/000-wrappers.R"] |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is downloaded every time
task fmt
runs, which is bad. @eitsupi do you know why this is executed while other setup tasks are skipped? Is it because this is a curl command and there's no way to know if it's outdated?