feat(rum-react)!: support react-router 6 #1410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devcorpio
commented
Aug 7, 2023
| * If the path/name is given as array, use the computed path | ||
| * to get the current transaction name | ||
| */ | ||
| function getTransactionName(name, props) { |
There was a problem hiding this comment.
FYI, react-router 6 doesn't allow to define array paths
devcorpio
commented
Aug 7, 2023
| } | ||
|
|
||
| export function getNumberOfUrlSegments(url) { | ||
| return url.split('/').filter(currentSegment => currentSegment.length > 0) |
There was a problem hiding this comment.
React-router 6 doesn't allow defining a regex as a path. Splitting by /is enough
devcorpio
force-pushed
the
react-router-v6
branch
from
6541d4a
to
458f480
Compare
devcorpio
force-pushed
the
react-router-v6
branch
from
458f480
to
84f9629
Compare
| @@ -51,10 +63,13 @@ function App() { | |||
| </li> | |||
| </ul> | |||
| <Suspense fallback={<div>Loading...</div>}> | |||
| <Switch> | |||
There was a problem hiding this comment.
Is this file even required, given there is no switch functionality in the new router, I would be fine with deleting this part of the code.
devcorpio
force-pushed
the
react-router-v6
branch
from
c6f80ab
to
46d13d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #1176
Summary
This PR makes it possible to instrument applications with react-router 6.
The API we expose will look like the following snippet:
All the routes defined within
<ApmRoutes>will be instrumented.IMPORTANT:
This PR will not instrument the mechanism named RouteProvider and there are no plans to do so in the midterm.
Note:
E2E are still pending to finishreact-router 6 doesn't support IE11. - E2E tests for React will no longer be executed for that browser.