Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rum-react)!: support react-router 6 #1410

Merged
merged 17 commits into from
Aug 8, 2023
Merged

feat(rum-react)!: support react-router 6 #1410

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
c24a782
chore: wip react router 6
devcorpio Aug 3, 2023
dd7f6a8
chore: muse effect more similar to componentDidMount
devcorpio Aug 7, 2023
3483ee5
chore: renaming route-change
devcorpio Aug 7, 2023
f2307b4
chore: modify comment
devcorpio Aug 7, 2023
32aa270
chore: ignore regex for react-router 6
devcorpio Aug 7, 2023
6fcd138
chore: finish unit test and remove old instrumentation
devcorpio Aug 7, 2023
4819d5c
chore: remove getApmRoute export
devcorpio Aug 7, 2023
614a822
chore: add redirect test
devcorpio Aug 7, 2023
d6263ca
chore: remove fit
devcorpio Aug 7, 2023
8c894d6
chore: handle apm inactive
devcorpio Aug 7, 2023
5887113
chore: adapt E2E tests
devcorpio Aug 7, 2023
dab4b82
chore: handle replace navType and complete all E2E
devcorpio Aug 7, 2023
f63ebb8
chore: pr review first round
devcorpio Aug 7, 2023
9767f3d
chore: add comment about useLayoutEffect
devcorpio Aug 8, 2023
84f9629
chore: drop ie11 for react tests
devcorpio Aug 8, 2023
2bcd939
chore: tests that checks if child update overrides queryparam behaviour
devcorpio Aug 8, 2023
46d13d5
chore: improve test
devcorpio Aug 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
112 changes: 15 additions & 97 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,8 +166,8 @@
"puppeteer": "^13.0.0",
"react": "^17.0.2",
"react-dom": "^17.0.2",
"react-router": "^5.2.0",
"react-router-dom": "^5.2.0",
"react-router": "^6.14.2",
"react-router-dom": "^6.14.2",
"regenerator-runtime": "^0.13.3",
"rimraf": "^3.0.0",
"rxjs": "^6.6.6",
Expand Down
2 changes: 1 addition & 1 deletion packages/rum-react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
},
"peerDependencies": {
"react": ">16.0.0",
"react-router-dom": ">4.0.0"
"react-router-dom": ">=6.0.0"
},
"browserslist": [
"ie 11"
Expand Down
86 changes: 0 additions & 86 deletions packages/rum-react/src/get-apm-route.js
View file
Open in desktop

This file was deleted.

Loading
Loading