-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[elasticsearch] Always report transport address in node_stats #36582
Merged
miltonhultgren
merged 4 commits into
elastic:main
from
miltonhultgren:es-scope-cluster-transport-address
Sep 20, 2023
Merged
[elasticsearch] Always report transport address in node_stats #36582
miltonhultgren
merged 4 commits into
elastic:main
from
miltonhultgren:es-scope-cluster-transport-address
Sep 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Sep 13, 2023
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
Collaborator
miltonhultgren
added
Team:Infra Monitoring UI - DEPRECATED
Infrastructure Monitoring UI team - DEPRECATED - Use Team:Monitoring
backport-v8.10.0
Automated backport with mergify
labels
Sep 13, 2023
botelastic
bot
removed
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Sep 13, 2023
klacabane
approved these changes
Sep 20, 2023
mergify bot
pushed a commit
that referenced
this pull request
Sep 20, 2023
(cherry picked from commit 24c3388)
miltonhultgren
added a commit
that referenced
this pull request
Sep 21, 2023
#36631) (cherry picked from commit 24c3388) Co-authored-by: Milton Hultgren <[email protected]>
Scholar-Li
pushed a commit
to Scholar-Li/beats
that referenced
this pull request
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-v8.10.0
Automated backport with mergify
Module:elasticsearch
Elasticsearch Beats modules
module
Team:Infra Monitoring UI - DEPRECATED
Infrastructure Monitoring UI team - DEPRECATED - Use Team:Monitoring
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
node_stats
metricset we were relying on Metricbeat to populateservice.address
and then later in the Stack Monitoring UI use that to display the IP of the nodes.Two problems existed with that approach:
service.address
with the IP/address of the host it connects to in order to collect the metrics, and if you're usingscope: cluster
that might be a load balancer or it will just be the address of the single node that gets connected, duplicated for all nodesThis PR changes so that we manually populate
service.address
by settingevent.Host
to the transport IP of the node being reported so that each node reports their unique transport IP.