Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

github-action: support check/lint/pre-commit #38175

Merged
merged 13 commits into from
Jun 4, 2024
Merged

github-action: support check/lint/pre-commit #38175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
8880d60
github-action: support check/lint
v1v Mar 4, 2024
242691b
github-action: enable precommit
v1v Mar 4, 2024
e2b8d36
remove unrequired steps
v1v Mar 4, 2024
b502de3
test
v1v Mar 4, 2024
786a42c
DRA
v1v Mar 4, 2024
4e42dc7
if changes in the workflow
v1v Mar 4, 2024
5df2fe0
fix regex
v1v Mar 4, 2024
7a8d2f3
Update .github/workflows/pre-commit.yml
v1v Mar 4, 2024
45c430d
Merge branch 'main' into feature/check-on-gh-actions
v1v Mar 12, 2024
2505ea4
keep previous setup
v1v May 15, 2024
d243bf9
Update Jenkinsfile
v1v May 15, 2024
0b74c3b
Update Jenkinsfile
v1v May 15, 2024
a9e6951
Merge branch 'main' into feature/check-on-gh-actions
v1v May 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions .github/workflows/pre-commit.yml
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are moving to BK, I would like to ask if we can split this PR into two smaller ones, one containing only the changes to the .pre-commit-config.yaml and then a follow-up to either try adding it to BK or, if that fails then the GH workflow.

Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
name: pre-commit

on:
pull_request:
push:
branches:
- main
- 7.1*
- 8.*

permissions:
contents: read

jobs:
pre-commit:
runs-on: ubuntu-latest
steps:
- uses: elastic/apm-pipeline-library/.github/actions/pre-commit@current
6 changes: 0 additions & 6 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,3 @@ repos:
rev: v4.4.0
hooks:
- id: check-merge-conflict

- repo: https://github.com/elastic/apm-pipeline-library.git
Comment on lines -6 to -7
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need to support this

rev: v1.1.397
hooks:
- id: check-jenkins-pipelines
files: ^(.ci/(.*\.groovy|Jenkinsfile)|Jenkinsfile)$
Loading