github-action: support check/lint/pre-commit #38175

v1v · 2024-03-04T17:09:31Z

Proposed commit message

WHAT: github-action: support check/lint/pre-commit.
WHY: remove support in Jenkins for low-hanging fruit. It was partially done in the past in action: run check, check-default and pre-commit #32723

Further actions

Update branch-protection:
- Add pre-commit / pre-commit

Checklist

My code follows the style guidelines of this project
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have made corresponding change to the default configuration files
I have added tests that prove my fix is effective or that my feature works
I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

[ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

use github actions instead

mergify · 2024-03-04T17:10:20Z

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @v1v? 🙏.
For such, you'll need to label your PR with:

The upcoming major version of the Elastic Stack
The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

elasticmachine · 2024-03-04T17:19:26Z

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Duration: 131 min 34 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.
/package : Generate the packages and run the E2E tests.
/beats-tester : Run the installation tests with beats-tester.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

.github/workflows/pre-commit.yml

v1v · 2024-03-04T17:59:51Z

.pre-commit-config.yaml

-
-   repo: https://github.com/elastic/apm-pipeline-library.git


There is no need to support this

v1v · 2024-03-04T18:00:32Z

deploy/kubernetes/Jenkinsfile.yml

@@ -12,11 +12,6 @@ when:
    tags: true                 ## for all the tags
 platform: "immutable && ubuntu-22" ## default label for all the stages
 stages:
-    checks:


For some reason these checks were not migrated in #32723

elasticmachine · 2024-03-12T09:08:32Z

💚 Build Succeeded

Buildkite Build
Commit: 45c430d

History

💚 Build #2984 succeeded 7a8d2f3
💚 Build #2981 succeeded 5df2fe0
💚 Build #2977 succeeded b502de3
💚 Build #2976 succeeded e2b8d36

cc @v1v

elasticmachine · 2024-03-12T09:09:03Z

💚 Build Succeeded

Buildkite Build
Commit: 45c430d

History

💚 Build #1770 succeeded 7a8d2f3
💚 Build #1767 succeeded 5df2fe0
💚 Build #1763 succeeded b502de3
💚 Build #1762 succeeded e2b8d36

cc @v1v

elasticmachine · 2024-03-12T09:09:05Z

💚 Build Succeeded

Buildkite Build
Commit: 45c430d

History

💚 Build #1777 succeeded 7a8d2f3
💚 Build #1774 succeeded 5df2fe0
💚 Build #1770 succeeded b502de3
💚 Build #1769 succeeded e2b8d36

cc @v1v

elasticmachine · 2024-03-12T09:09:07Z

💚 Build Succeeded

Buildkite Build
Commit: 45c430d

History

💚 Build #933 succeeded 7a8d2f3
💚 Build #930 succeeded 5df2fe0
💚 Build #926 succeeded b502de3
💚 Build #925 succeeded e2b8d36

cc @v1v

elasticmachine · 2024-03-12T09:12:43Z

💔 Build Failed

Buildkite Build
Commit: 45c430d

Failed CI Steps

History

💚 Build #3406 succeeded 7a8d2f3

cc @v1v

dliappis

LGTM

Jenkinsfile

v1v · 2024-03-14T09:23:11Z

I don't know who has the superpower to merge, but! It will require a couple of further changes afterwards, as noted in the description.

Jenkinsfile

mergify · 2024-05-15T14:41:54Z

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b feature/check-on-gh-actions upstream/feature/check-on-gh-actions
git merge upstream/main
git push upstream feature/check-on-gh-actions

Jenkinsfile

alexsapran · 2024-05-16T08:30:43Z

.github/workflows/pre-commit.yml

Since we are moving to BK, I would like to ask if we can split this PR into two smaller ones, one containing only the changes to the .pre-commit-config.yaml and then a follow-up to either try adding it to BK or, if that fails then the GH workflow.

pazone · 2024-06-04T00:32:22Z

LGTM

(cherry picked from commit bef2cc6) # Conflicts: # .pre-commit-config.yaml

(cherry picked from commit bef2cc6)

…39799)

…39797)

v1v added 3 commits March 4, 2024 18:04

github-action: support check/lint

8880d60

github-action: enable precommit

242691b

remove unrequired steps

e2b8d36

use github actions instead

botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Mar 4, 2024

mergify bot assigned v1v Mar 4, 2024

test

b502de3

v1v added 3 commits March 4, 2024 18:22

DRA

786a42c

if changes in the workflow

4e42dc7

fix regex

5df2fe0

v1v marked this pull request as ready for review March 4, 2024 17:27

v1v requested review from a team as code owners March 4, 2024 17:27

v1v requested review from fearful-symmetry, leehinman, gsantoro and MichaelKatsoulis March 4, 2024 17:27

v1v commented Mar 4, 2024

View reviewed changes

.github/workflows/pre-commit.yml Outdated Show resolved Hide resolved

botelastic bot added Team:Automation Label for the Observability productivity team and removed needs_team Indicates that the issue/PR needs a Team:* label labels Mar 4, 2024

Update .github/workflows/pre-commit.yml

7a8d2f3

v1v commented Mar 4, 2024

View reviewed changes

Merge branch 'main' into feature/check-on-gh-actions

45c430d

v1v requested a review from a team as a code owner March 12, 2024 09:05

v1v enabled auto-merge (squash) March 12, 2024 09:31

v1v added backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.13.0 Automated backport with mergify labels Mar 12, 2024

dliappis approved these changes Mar 12, 2024

View reviewed changes

cmacknz reviewed Mar 12, 2024

View reviewed changes

Jenkinsfile Outdated Show resolved Hide resolved

v1v mentioned this pull request Mar 25, 2024

Deploy k8s pipeline migration to Buildkite #38460

Closed

6 tasks

keep previous setup

2505ea4

v1v commented May 15, 2024

View reviewed changes

Jenkinsfile Outdated Show resolved Hide resolved

Update Jenkinsfile

d243bf9

v1v commented May 15, 2024

View reviewed changes

Jenkinsfile Outdated Show resolved Hide resolved

v1v added 2 commits May 15, 2024 16:42

Update Jenkinsfile

0b74c3b

Merge branch 'main' into feature/check-on-gh-actions

a9e6951

dliappis requested a review from alexsapran May 15, 2024 14:51

dliappis added the backport-v8.14.0 Automated backport with mergify label May 15, 2024

alexsapran reviewed May 16, 2024

View reviewed changes

cmacknz approved these changes Jun 4, 2024

View reviewed changes

v1v merged commit bef2cc6 into main Jun 4, 2024
10 checks passed

v1v deleted the feature/check-on-gh-actions branch June 4, 2024 17:48

mergify bot pushed a commit that referenced this pull request Jun 4, 2024

github-action: support check/lint/pre-commit (#38175)

36df1fe

(cherry picked from commit bef2cc6) # Conflicts: # .pre-commit-config.yaml

mergify bot mentioned this pull request Jun 4, 2024

[7.17](backport #38175) github-action: support check/lint/pre-commit #39797

Merged

8 tasks

mergify bot pushed a commit that referenced this pull request Jun 4, 2024

github-action: support check/lint/pre-commit (#38175)

bb64238

(cherry picked from commit bef2cc6) # Conflicts: # .pre-commit-config.yaml

mergify bot mentioned this pull request Jun 4, 2024

[8.13](backport #38175) github-action: support check/lint/pre-commit #39798

Closed

8 tasks

mergify bot pushed a commit that referenced this pull request Jun 4, 2024

github-action: support check/lint/pre-commit (#38175)

dab606e

(cherry picked from commit bef2cc6)

mergify bot mentioned this pull request Jun 4, 2024

[8.14](backport #38175) github-action: support check/lint/pre-commit #39799

Merged

8 tasks

v1v pushed a commit that referenced this pull request Jun 5, 2024

[8.14](backport #38175) github-action: support check/lint/pre-commit (#…

14bc39c

…39799)

v1v pushed a commit that referenced this pull request Jun 10, 2024

[7.17](backport #38175) github-action: support check/lint/pre-commit (#…

b6f4a46

…39797)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

github-action: support check/lint/pre-commit #38175

github-action: support check/lint/pre-commit #38175

v1v commented Mar 4, 2024 •

edited

Loading

mergify bot commented Mar 4, 2024

elasticmachine commented Mar 4, 2024 •

edited

Loading

Build stats

v1v Mar 4, 2024

v1v Mar 4, 2024

elasticmachine commented Mar 12, 2024

elasticmachine commented Mar 12, 2024

elasticmachine commented Mar 12, 2024

elasticmachine commented Mar 12, 2024

elasticmachine commented Mar 12, 2024 •

edited

Loading

dliappis left a comment

v1v commented Mar 14, 2024

mergify bot commented May 15, 2024

alexsapran May 16, 2024

pazone commented Jun 4, 2024

github-action: support check/lint/pre-commit #38175

github-action: support check/lint/pre-commit #38175

Conversation

v1v commented Mar 4, 2024 • edited Loading

Proposed commit message

Further actions

Checklist

Author's Checklist

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

mergify bot commented Mar 4, 2024

elasticmachine commented Mar 4, 2024 • edited Loading

💚 Build Succeeded

Build stats

❕ Flaky test report

🤖 GitHub comments

v1v Mar 4, 2024

Choose a reason for hiding this comment

v1v Mar 4, 2024

Choose a reason for hiding this comment

elasticmachine commented Mar 12, 2024

💚 Build Succeeded

History

elasticmachine commented Mar 12, 2024

💚 Build Succeeded

History

elasticmachine commented Mar 12, 2024

💚 Build Succeeded

History

elasticmachine commented Mar 12, 2024

💚 Build Succeeded

History

elasticmachine commented Mar 12, 2024 • edited Loading

💔 Build Failed

Failed CI Steps

History

dliappis left a comment

Choose a reason for hiding this comment

v1v commented Mar 14, 2024

mergify bot commented May 15, 2024

alexsapran May 16, 2024

Choose a reason for hiding this comment

pazone commented Jun 4, 2024

v1v commented Mar 4, 2024 •

edited

Loading

elasticmachine commented Mar 4, 2024 •

edited

Loading

elasticmachine commented Mar 12, 2024 •

edited

Loading