style(theme): change point and isolated point style and visibility #2525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1011615.
markov00
added
:interactions
nickofthyme
reviewed
Sep 19, 2024
packages/charts/src/chart_types/xy_chart/state/selectors/get_debug_state.ts
Show resolved
Hide resolved
nickofthyme
approved these changes
Sep 20, 2024
packages/charts/src/chart_types/xy_chart/renderer/dom/highlighter.tsx
Outdated
Show resolved
Hide resolved
packages/charts/src/chart_types/xy_chart/renderer/canvas/points.ts
Outdated
Show resolved
Hide resolved
|
buildkite update screenshots |
nickofthyme
pushed a commit
that referenced
this pull request
Sep 23, 2024
# [67.0.0](v66.1.1...v67.0.0) (2024-09-23) ### Bug Fixes * **deps:** update dependency @elastic/eui to ^95.8.0 ([#2504](#2504)) ([1ca5dd9](1ca5dd9)) * **deps:** update dependency @playwright/test to ^1.46.1 ([#2511](#2511)) ([b99b3e6](b99b3e6)) * **deps:** update dependency json-schema-to-typescript to v15.0.1 ([#2510](#2510)) ([a606d72](a606d72)) ### Styles * **theme:** change point and isolated point style and visibility ([#2525](#2525)) ([87de6c2](87de6c2)) ### BREAKING CHANGES * **theme:** the `isolatedPoint` style doesn't contain the `radius` parameter anymore. The radius is derived from the `line.strokeWidth` parameter.
Closed
3 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix #2458
BREAKING CHANGE: There is a visual difference in the way the points are rendered and the way the style is