Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow nullable lifecycle and data_retention template values #2160

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dakrone
Copy link
Member

@dakrone dakrone commented Jun 27, 2023

These keys allow using an explicit null as the value to "unset" the configuration when merging multiple component templates. As related to the merging tables seen in elastic/elasticsearch#95979 (comment)

Relates also to the discussion in #2049

These keys allow using an explicit `null` as the value to "unset" the configuration when merging multiple component templates. As related to the merging tables seen in elastic/elasticsearch#95979 (comment)

Relates also to the discussion in elastic#2049
@dakrone
Copy link
Member Author

dakrone commented Jun 27, 2023

I'm not sure how to fix the CI failure, it says: Error: Input required and not supplied: token

@flobernd
Copy link
Member

flobernd commented Jun 27, 2023

I think the CI workflow is faulty. This expression:

if: github.repository_owner == 'elastic' # this action will fail if executed from a fork

will always be true as github.repository_owner refers to the "target" repository for pull_request triggers.

It should instead check github.event.pull_request.head.repo.owner (if I remember correctly).

@@ -66,5 +66,5 @@ export class IndexTemplateMapping {
* @availability stack since=8.8.0 stability=experimental
* @availability serverless stability=experimental
*/
lifecycle?: DataLifecycle
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dakrone this shouldn't be nullable anymore as we now have the enabled field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants