Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow nullable lifecycle and data_retention template values #2160

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow nullable lifecycle and data_retention template values #2160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 34 additions & 10 deletions output/schema/schema.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions output/typescript/types.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion specification/indices/_types/DataLifecycle.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import { ByteSize } from '@_types/common'
* Data lifecycle denotes that a data stream is managed by DLM and contains the configuration.
*/
export class DataLifecycle {
data_retention?: Duration
data_retention?: Duration | null
}

/**
Expand Down
2 changes: 1 addition & 1 deletion specification/indices/put_index_template/IndicesPutIndexTemplateRequest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,5 +66,5 @@ export class IndexTemplateMapping {
* @availability stack since=8.8.0 stability=experimental
* @availability serverless stability=experimental
*/
lifecycle?: DataLifecycle
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dakrone this shouldn't be nullable anymore as we now have the enabled field.

lifecycle?: DataLifecycle | null
}