Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler: fix required body value #2463

Merged
merged 2 commits into from
Mar 25, 2024
Merged

Compiler: fix required body value #2463

merged 2 commits into from
Mar 25, 2024

Conversation

Anaethelion
Copy link
Contributor

Propagate question mark from typescript spec
Overrides value taken from json spec file
Add an endpoint validation to detect discrenpancy

@Anaethelion Anaethelion requested a review from a team as a code owner March 22, 2024 09:46
flobernd added a commit that referenced this pull request Mar 22, 2024
@flobernd flobernd mentioned this pull request Mar 22, 2024
Copy link
Member

@flobernd flobernd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you.

flobernd added a commit that referenced this pull request Mar 25, 2024
@flobernd
Copy link
Member

@Anaethelion I merged the predecessor PR. I think this should be good to go now 🙂

@Anaethelion Anaethelion merged commit 0f41f4f into main Mar 25, 2024
7 checks passed
@Anaethelion Anaethelion deleted the required_body_from_ts branch March 25, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants