Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CHORE] Bump Docker to use Node v18.18.2 #7293

Merged
merged 2 commits into from
Oct 18, 2023
Merged

[CHORE] Bump Docker to use Node v18.18.2 #7293

merged 2 commits into from
Oct 18, 2023

Conversation

1Copenut
Copy link
Contributor

@1Copenut 1Copenut commented Oct 18, 2023 •
edited by cee-chen
Loading

Summary

PR bumps our Docker Node image and daily driver Node to version 18.18.2 to match the Kibana team.

QA

  • QA will be verified manually on Buildkite UI. All PR jobs (tests and deploy docs) should pass with no issues.
  • Contributor has verified the following on their local machine:
    • nvm install 18.18.2
    • nvm alias default 18.18.2
    • yarn lint
    • yarn test-unit
    • yarn test-cypress
  • For reviewers, please spot check the latest Node version on local machines
    • nvm install 18.18.2
    • nvm alias default 18.18.2
    • yarn lint
    • yarn test-unit
    • yarn test-cypress

@1Copenut 1Copenut self-assigned this Oct 18, 2023
@kibanamachine
Copy link

Preview staging links for this PR:

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @1Copenut

@1Copenut 1Copenut marked this pull request as ready for review October 18, 2023 15:24
@1Copenut 1Copenut requested a review from a team as a code owner October 18, 2023 15:24
cee-chen
cee-chen approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@cee-chen cee-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 Checked out and QA'd locally, everything looks great!

@1Copenut 1Copenut merged commit 5d1441d into elastic:main Oct 18, 2023
14 of 15 checks passed
@1Copenut 1Copenut deleted the chore/docker-node-18.18.2 branch October 18, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cee-chen cee-chen cee-chen approved these changes

Assignees

@1Copenut 1Copenut

Labels
chore infrastructure skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@1Copenut @kibanamachine @elasticmachine @cee-chen