Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] Bump Docker to use Node v18.18.2 #7293

Merged
merged 2 commits into from
Oct 18, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .buildkite/scripts/pipeline_test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ DOCKER_OPTIONS=(
--user="$(id -u):$(id -g)"
--volume="$(pwd):/app"
--workdir=/app
docker.elastic.co/eui/ci:5.5
docker.elastic.co/eui/ci:5.6
)

case $TEST_TYPE in
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
18.18.1
18.18.2
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"main": "lib",
"module": "es",
"types": "eui.d.ts",
"docker_image": "18.18.1",
"docker_image": "18.18.2",
"engines": {
"node": "16.x || 18.x || >=20.0"
},
Expand Down
2 changes: 1 addition & 1 deletion scripts/deploy/build_docs
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

set -e

NODE_IMG="docker.elastic.co/eui/ci:5.5"
NODE_IMG="docker.elastic.co/eui/ci:5.6"

# Compile using node image
echo "Building docs using ${NODE_IMG} Docker image"
Expand Down
2 changes: 1 addition & 1 deletion scripts/docker-ci/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# https://github.com/zenato/docker-puppeteer/blob/master/Dockerfile

# >=12.0 required (for cypress). v18 is LTS.
FROM --platform=linux/amd64 node:18.18.1-slim
FROM --platform=linux/amd64 node:18.18.2-slim

SHELL ["/bin/bash", "-o", "pipefail", "-c"]

Expand Down
4 changes: 2 additions & 2 deletions scripts/test-a11y-docker.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
const { execSync } = require('child_process');

execSync('docker pull docker.elastic.co/eui/ci:5.5', {
execSync('docker pull docker.elastic.co/eui/ci:5.6', {
stdio: 'inherit',
});
/* eslint-disable-next-line no-multi-str */
Expand All @@ -9,7 +9,7 @@ execSync(
-i --rm --cap-add=SYS_ADMIN --volume=$(pwd):/app --workdir=/app \
-e GIT_COMMITTER_NAME=test -e GIT_COMMITTER_EMAIL=test -e HOME=/tmp \
--user=$(id -u):$(id -g) \
docker.elastic.co/eui/ci:5.5 \
docker.elastic.co/eui/ci:5.6 \
bash -c \'npm config set spin false \
&& /opt/yarn*/bin/yarn \
&& yarn cypress install \
Expand Down
4 changes: 2 additions & 2 deletions scripts/test-docker.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
const { execSync } = require('child_process');

execSync('docker pull docker.elastic.co/eui/ci:5.5', {
execSync('docker pull docker.elastic.co/eui/ci:5.6', {
stdio: 'inherit',
});
/* eslint-disable-next-line no-multi-str */
Expand All @@ -9,7 +9,7 @@ execSync(
-i --rm --cap-add=SYS_ADMIN --volume=$(pwd):/app --workdir=/app \
-e GIT_COMMITTER_NAME=test -e GIT_COMMITTER_EMAIL=test -e HOME=/tmp \
--user=$(id -u):$(id -g) \
docker.elastic.co/eui/ci:5.5 \
docker.elastic.co/eui/ci:5.6 \
bash -c \'/opt/yarn*/bin/yarn \
&& yarn cypress install \
&& NODE_OPTIONS="--max-old-space-size=2048" npm run test-ci \
Expand Down
Loading