Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiPageHeaderContent] Improve responsiveness #8044

Merged
merged 10 commits into from
Sep 26, 2024
+469 −392
Merged

[EuiPageHeaderContent] Improve responsiveness #8044

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
870beb3
[EuiPageHeaderContent] Various cleanup
cee-chen Sep 25, 2024
c7ec7dc
Add story for legacy `childrenOnly` UI
cee-chen Sep 25, 2024
a1c3b5f
Add VRT illustrating problem being fixed
cee-chen Sep 25, 2024
1014609
Move tabs outside of left side on desktop and into true bottom
cee-chen Sep 25, 2024
cc5f1d7
Add VRT illustrating problem being fixed
cee-chen Sep 25, 2024
eb70ea7
Improve responsive wrapping at smaller container sizes
cee-chen Sep 25, 2024
7ac93fc
[cleanup] Remove unnecessary return ternary
cee-chen Sep 25, 2024
248139a
Update downstream EuiPageTemplate/EuiPageHeader VRT + snapshots
cee-chen Sep 25, 2024
3a96c32
changelog
cee-chen Sep 25, 2024
4384aa4
[PR feedback] Spelling 2: Spelling Harder
cee-chen Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified ..._desktop_Layout_EuiPage_EuiPageHeader_EuiPageHeaderContent_Wrapping_Content.png
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like your approach to adding before/after commits for VRT 👏 🧠

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's really helpful for me to confirm I'm actually fixing stuff! And also makes before/after screenshots in the PR description a breeze! 😎

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified .../chrome_mobile_Layout_EuiPage_EuiPageHeader_EuiPageHeaderContent_Playground.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
7 changes: 4 additions & 3 deletions packages/eui/src/components/page/page_header/page_header_content.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,10 +317,9 @@ export const EuiPageHeaderContent: FunctionComponent<
);

let bottomContentNode;
if (childrenNode || (tabsNode && pageTitleNode)) {
if (tabsNode && pageTitleNode) {
bottomContentNode = (
<div className="euiPageHeaderContent__bottom">
{childrenNode}
{pageTitleNode && tabsNode}
</div>
);
Expand All @@ -336,13 +335,15 @@ export const EuiPageHeaderContent: FunctionComponent<
<>
{tabsNode}
{descriptionNode}
{childrenNode}
</>
);
} else {
leftSideOrder = (
<>
{pageTitleNode}
{descriptionNode}
{childrenNode}
</>
);
}
Expand Down Expand Up @@ -402,10 +403,10 @@ export const EuiPageHeaderContent: FunctionComponent<
>
<EuiFlexItem>
{leftSideOrder}
{bottomContentNode}
</EuiFlexItem>
{rightSideFlexItem}
</EuiFlexGroup>
{bottomContentNode}
</div>
);
};