Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiPageHeaderContent] Improve responsiveness #8044

Merged
merged 10 commits into from
Sep 26, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like your approach to adding before/after commits for VRT 👏 🧠

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's really helpful for me to confirm I'm actually fixing stuff! And also makes before/after screenshots in the PR description a breeze! 😎

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
Expand Up @@ -116,3 +116,22 @@ export const LegacyChildrenOnly: Story = {
),
},
};

/**
* Visual regression tests
*/

export const WrappingContent: Story = {
tags: ['vrt-only'],
args: {
pageTitle: 'Lots of wrapping content',
description:
'Lorem ipsum odor amet, consectetuer adipiscing elit. Montes justo potenti per himenaeos non nascetur nulla taciti consequat. Curae blandit integer molestie quis taciti curabitur facilisi ullamcorper mi. Mus parturient ultrices lacus nascetur tellus scelerisque. Auctor senectus eu rhoncus eget laoreet nunc amet potenti penatibus. Mi ad iaculis diam feugiat egestas malesuada. Commodo a cras malesuada duis vel tempus per! Rhoncus montes aptent vitae efficitur eget ornare eu curae. Ut semper sed augue mattis proin imperdiet tempus.',
tabs: Array.from({ length: 7 }).map(() => ({
label: 'Long loooong tab',
})),
rightSideItems: Array.from({ length: 5 }).map(() => (
<EuiButton>Lots o buttons</EuiButton>
mgadewoll marked this conversation as resolved.
Show resolved Hide resolved
)),
},
};