Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

darwin: Remove duplicate -lproc linker flag (#192) #195

Merged
merged 2 commits into from
Nov 29, 2023
Merged

darwin: Remove duplicate -lproc linker flag (#192) #195

merged 2 commits into from
Nov 29, 2023

Conversation

xmichelo
Copy link
Contributor

darwin: Remove duplicate -lproc linker flag to avoid a warning on macOS Sonoma. (#192)

andrewkroh
andrewkroh previously approved these changes Nov 28, 2023
View reviewed changes
@andrewkroh andrewkroh added the bug Something isn't working label Nov 28, 2023
@andrewkroh andrewkroh enabled auto-merge (squash) November 28, 2023 22:15
@andrewkroh andrewkroh added the Team:Security-External Integrations Label for the Security External Integrations team label Nov 28, 2023
@andrewkroh andrewkroh requested a review from a team November 28, 2023 22:17
andrewkroh
andrewkroh approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@andrewkroh andrewkroh requested a review from a team November 29, 2023 08:03
efd6
efd6 approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unable to reproduce the issue on an intel mac running sonoma, but equally, removing it doesn't cause the build to fail, so LGTM.

@andrewkroh andrewkroh merged commit 35e55cd into elastic:main Nov 29, 2023
24 checks passed
@mfridman mfridman mentioned this pull request Dec 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

@efd6 efd6 efd6 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working Team:Security-External Integrations Label for the Security External Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xmichelo @andrewkroh @efd6