[servicenow_cmdb] Initial release of ServiceNow CMDB #11521

muskan-agarwal26 · 2024-10-25T12:14:18Z

Proposed commit message

Create New integration package servicenow_cmdb.

Added event data stream.
Added data collection logic for the data stream.
Added the ingest pipeline for the data stream.
Mapped fields according to the ECS schema and added Fields metadata in the appropriate yml files.
Added dashboard and visualizations.
Added pipeline test for the data stream.
Added system test cases for the data stream.

Checklist

I have reviewed tips for building integrations and this pull request is aligned with them.
I have verified that all data streams collect metrics or logs.
I have added an entry to my package's changelog.yml file.
I have verified that Kibana version constraints are current according to guidelines.
I have verified that any added dashboard complies with Kibana's Dashboard good practices

How to test this PR locally

Clone integrations repo.
Install elastic package locally.
Start elastic stack using elastic-package.
Move to integrations/packages/servicenow_cmdb directory.
Run the following command to run tests.

elastic-package test

Run asset tests for the package
2024/10/25 12:04:07  INFO License text found in "/home/devuser/integrations/LICENSE.txt" will be included in package
--- Test results for package: servicenow_cmdb - START ---
╭─────────────────┬─────────────┬───────────┬──────────────────────────────────────────────────────────────────────────┬────────┬──────────────╮
│ PACKAGE         │ DATA STREAM │ TEST TYPE │ TEST NAME                                                                │ RESULT │ TIME ELAPSED │
├─────────────────┼─────────────┼───────────┼──────────────────────────────────────────────────────────────────────────┼────────┼──────────────┤
│ servicenow_cmdb │             │ asset     │ dashboard servicenow_cmdb-014c13b4-59bc-4bfa-bcb2-fdc1828020bf is loaded │ PASS   │      1.874µs │
│ servicenow_cmdb │             │ asset     │ dashboard servicenow_cmdb-0305f883-12a8-4021-af73-fbe05e797c3f is loaded │ PASS   │        289ns │
│ servicenow_cmdb │             │ asset     │ dashboard servicenow_cmdb-22d413b7-ffb5-450f-b5f8-7dcd54fab22f is loaded │ PASS   │        363ns │
│ servicenow_cmdb │             │ asset     │ dashboard servicenow_cmdb-297414cc-3b65-40b1-b15b-e33cf676b3bf is loaded │ PASS   │        286ns │
│ servicenow_cmdb │             │ asset     │ dashboard servicenow_cmdb-488772bc-4ce5-48c6-9e8a-d948439dbf39 is loaded │ PASS   │        255ns │
│ servicenow_cmdb │             │ asset     │ dashboard servicenow_cmdb-648308f9-ebdf-46fe-b6ce-b90dfcf2d1dd is loaded │ PASS   │        389ns │
│ servicenow_cmdb │             │ asset     │ dashboard servicenow_cmdb-b182c6a6-3b4e-413f-899d-dd255b1a3623 is loaded │ PASS   │        338ns │
│ servicenow_cmdb │             │ asset     │ dashboard servicenow_cmdb-b4795d3e-8c8b-48b2-900e-edc89db4d336 is loaded │ PASS   │        324ns │
│ servicenow_cmdb │             │ asset     │ dashboard servicenow_cmdb-d2eb3f0c-4ddb-4683-afab-2820d2616ca2 is loaded │ PASS   │        330ns │
│ servicenow_cmdb │             │ asset     │ dashboard servicenow_cmdb-d8977587-d9b4-4487-b321-a8402da07d48 is loaded │ PASS   │        333ns │
│ servicenow_cmdb │             │ asset     │ dashboard servicenow_cmdb-d929c3a1-7af8-428e-8357-8b2e8d3e3050 is loaded │ PASS   │        352ns │
│ servicenow_cmdb │             │ asset     │ dashboard servicenow_cmdb-e6093b0d-38a6-4b05-8354-4bbaef28b667 is loaded │ PASS   │        414ns │
│ servicenow_cmdb │             │ asset     │ search servicenow_cmdb-00004bce-eac2-46d4-bb4e-ce6849c50a36 is loaded    │ PASS   │        291ns │
│ servicenow_cmdb │             │ asset     │ search servicenow_cmdb-01396f16-041b-4ec5-b104-d29fe68f09ad is loaded    │ PASS   │        312ns │
│ servicenow_cmdb │             │ asset     │ search servicenow_cmdb-046f04ce-7f31-4929-81fa-34561fb369f0 is loaded    │ PASS   │        312ns │
│ servicenow_cmdb │             │ asset     │ search servicenow_cmdb-1c323098-190c-4592-aca5-dd9e64de540b is loaded    │ PASS   │        356ns │
│ servicenow_cmdb │             │ asset     │ search servicenow_cmdb-26f2b1af-7d7d-4578-b325-322ac4c783fa is loaded    │ PASS   │        310ns │
│ servicenow_cmdb │             │ asset     │ search servicenow_cmdb-44db573d-f3e6-4f59-b1a4-328040220991 is loaded    │ PASS   │        340ns │
│ servicenow_cmdb │             │ asset     │ search servicenow_cmdb-722e7751-818d-41e2-b7ac-fcc90bb8241b is loaded    │ PASS   │        465ns │
│ servicenow_cmdb │             │ asset     │ search servicenow_cmdb-a5b0060e-4ace-4c9f-96e1-2d815bc9dd28 is loaded    │ PASS   │        386ns │
│ servicenow_cmdb │             │ asset     │ search servicenow_cmdb-afa470f8-4e19-4fee-8b17-5649a7b0ae51 is loaded    │ PASS   │        442ns │
│ servicenow_cmdb │             │ asset     │ search servicenow_cmdb-b9cc24b4-0cfe-458c-8645-23838623ca09 is loaded    │ PASS   │        390ns │
│ servicenow_cmdb │             │ asset     │ search servicenow_cmdb-e28e5e66-d00d-4e2c-af2e-a09d0d261b05 is loaded    │ PASS   │        405ns │
│ servicenow_cmdb │ event       │ asset     │ index_template logs-servicenow_cmdb.event is loaded                      │ PASS   │        401ns │
│ servicenow_cmdb │ event       │ asset     │ ingest_pipeline logs-servicenow_cmdb.event-0.1.0 is loaded               │ PASS   │        145ns │
╰─────────────────┴─────────────┴───────────┴──────────────────────────────────────────────────────────────────────────┴────────┴──────────────╯
--- Test results for package: servicenow_cmdb - END   ---
Done
Run pipeline tests for the package
--- Test results for package: servicenow_cmdb - START ---
╭─────────────────┬─────────────┬───────────┬───────────────────────────────────────────┬────────┬──────────────╮
│ PACKAGE         │ DATA STREAM │ TEST TYPE │ TEST NAME                                 │ RESULT │ TIME ELAPSED │
├─────────────────┼─────────────┼───────────┼───────────────────────────────────────────┼────────┼──────────────┤
│ servicenow_cmdb │ event       │ pipeline  │ (ingest pipeline warnings test-event.log) │ PASS   │  283.07434ms │
│ servicenow_cmdb │ event       │ pipeline  │ test-event.log                            │ PASS   │ 2.375082204s │
╰─────────────────┴─────────────┴───────────┴───────────────────────────────────────────┴────────┴──────────────╯
--- Test results for package: servicenow_cmdb - END   ---
Done
Run policy tests for the package
--- Test results for package: servicenow_cmdb - START ---
No test results
--- Test results for package: servicenow_cmdb - END   ---
Done
Run static tests for the package
--- Test results for package: servicenow_cmdb - START ---
╭─────────────────┬─────────────┬───────────┬──────────────────────────┬────────┬──────────────╮
│ PACKAGE         │ DATA STREAM │ TEST TYPE │ TEST NAME                │ RESULT │ TIME ELAPSED │
├─────────────────┼─────────────┼───────────┼──────────────────────────┼────────┼──────────────┤
│ servicenow_cmdb │ event       │ static    │ Verify sample_event.json │ PASS   │ 255.650047ms │
╰─────────────────┴─────────────┴───────────┴──────────────────────────┴────────┴──────────────╯
--- Test results for package: servicenow_cmdb - END   ---
Done
Run system tests for the package
2024/10/25 12:04:18  INFO License text found in "/home/devuser/integrations/LICENSE.txt" will be included in package
2024/10/25 12:05:08  INFO Write container logs to file: /home/devuser/integrations/build/container-logs/servicenow_cmdb-1729838108086618108.log
2024/10/25 12:05:17  INFO Write container logs to file: /home/devuser/integrations/build/container-logs/elastic-agent-1729838117386925419.log
--- Test results for package: servicenow_cmdb - START ---
╭─────────────────┬─────────────┬───────────┬───────────┬────────┬───────────────╮
│ PACKAGE         │ DATA STREAM │ TEST TYPE │ TEST NAME │ RESULT │  TIME ELAPSED │
├─────────────────┼─────────────┼───────────┼───────────┼────────┼───────────────┤
│ servicenow_cmdb │ event       │ system    │ default   │ PASS   │ 40.132021147s │
╰─────────────────┴─────────────┴───────────┴───────────┴────────┴───────────────╯
--- Test results for package: servicenow_cmdb - END   ---
Done

Screenshots

kcreddy · 2024-10-28T04:10:23Z

/test

elasticmachine · 2024-10-28T04:10:36Z

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

packages/servicenow_cmdb/data_stream/event/agent/stream/cel.yml.hbs

1. Implemented changes. 2. Added package inside codeowners.

efd6

This PR is too big to be safely reviewed in one sitting. I've done the best that I can, but I will take another look later.

packages/servicenow_cmdb/_dev/build/docs/README.md

efd6 · 2024-10-28T22:50:49Z

packages/servicenow_cmdb/_dev/build/docs/README.md

+The ServiceNow CMDB integration can be used in three different modes to collect logs:
+- AWS S3 polling mode: ServiceNow CMDB writes data to S3, and Elastic Agent polls the S3 bucket by listing its contents and reading new files. Refer this [link](https://www.servicenow.com/community/now-platform-forum/aws-s3-integration-with-servicenow/td-p/1121852) to integrate AWS S3 with ServiceNow for retrieving logs into an S3 bucket.
+- AWS S3 SQS mode: ServiceNow CMDB writes data to S3, S3 sends a notification of a new object to SQS, the Elastic Agent receives the notification from SQS, and then reads the S3 object. Multiple agents can be used in this mode.
+- REST API mode: ServiceNow CMDB offers table APIs to retrieve data from its tables, the Elastic Agent polls these APIs to list their contents and read any new data. Visit this [link](https://developer.servicenow.com/dev.do#!/reference/api/washingtondc/rest/c_TableAPI#table-GET) for additional information about REST APIs.


Suggested change

- REST API mode: ServiceNow CMDB offers table APIs to retrieve data from its tables, the Elastic Agent polls these APIs to list their contents and read any new data. Visit this [link](https://developer.servicenow.com/dev.do#!/reference/api/washingtondc/rest/c_TableAPI#table-GET) for additional information about REST APIs.

- REST API mode: ServiceNow CMDB offers table APIs to retrieve data from its tables; the Elastic Agent polls these APIs to list their contents and read any new data. Visit this [link](https://developer.servicenow.com/dev.do#!/reference/api/washingtondc/rest/c_TableAPI#table-GET) for additional information about REST APIs.

Sorry, also Visit this [page](https://developer.servicenow.com/dev.do#!/reference/api/washingtondc/rest/c_TableAPI#table-GET) for additional information about REST APIs.

packages/servicenow_cmdb/_dev/build/docs/README.md

efd6 · 2024-10-29T00:02:43Z

packages/servicenow_cmdb/data_stream/event/elasticsearch/ingest_pipeline/default.yml

+      field: event.kind
+      tag: set_event_kind_to_event
+      value: event
+      if: ctx.servicenow_cmdb?.event?.table_name != null && ['cmdb_ci_service','change_task','cmdb_rel_ci','cmdb_ci_infra_service','cmdb_ci','cmdb','cmdb_ci_vm','cmdb_ci_db_instance','cmdb_ci_appl','cmdb_ci_esx_server'].contains(ctx.servicenow_cmdb.event.table_name)


These allocate each time they are executed. They can be expressed as a set of disjunctions in a condition.

Suggested change

if: ctx.servicenow_cmdb?.event?.table_name != null && ['cmdb_ci_service','change_task','cmdb_rel_ci','cmdb_ci_infra_service','cmdb_ci','cmdb','cmdb_ci_vm','cmdb_ci_db_instance','cmdb_ci_appl','cmdb_ci_esx_server'].contains(ctx.servicenow_cmdb.event.table_name)

if: >-

ctx.servicenow_cmdb?.event?.table_name != null && (

ctx.servicenow_cmdb.event.table_name == 'cmdb_ci_service' ||

ctx.servicenow_cmdb.event.table_name == 'change_task' ||

ctx.servicenow_cmdb.event.table_name == 'cmdb_rel_ci' ||

ctx.servicenow_cmdb.event.table_name == 'cmdb_ci_infra_service' ||

ctx.servicenow_cmdb.event.table_name == 'cmdb_ci' ||

ctx.servicenow_cmdb.event.table_name == 'cmdb' ||

ctx.servicenow_cmdb.event.table_name == 'cmdb_ci_vm' ||

ctx.servicenow_cmdb.event.table_name == 'cmdb_ci_db_instance' ||

ctx.servicenow_cmdb.event.table_name == 'cmdb_ci_appl' ||

ctx.servicenow_cmdb.event.table_name == 'cmdb_ci_esx_server'

)

efd6 · 2024-10-29T00:15:00Z

packages/servicenow_cmdb/data_stream/event/manifest.yml

+      - name: url
+        type: url
+        title: URL
+        description: URL of ServiceNow instance. It should follow the given format, https://<instance_id>.service-now.com.


Suggested change

description: URL of ServiceNow instance. It should follow the given format, https://<instance_id>.service-now.com.

description: URL of ServiceNow instance. It should follow the given format, https://\<instance_id\>.service-now.com.

(please check whether this is necessary)

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

elastic-sonarqube · 2024-10-30T21:25:45Z

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
93.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

elasticmachine · 2024-10-30T21:25:49Z

💚 Build Succeeded

Buildkite Build
Commit: 775ffd3

History

💔 Build #17598 failed 7c65193

efd6 · 2024-10-30T22:08:17Z

...s/servicenow_cmdb/kibana/dashboard/servicenow_cmdb-014c13b4-59bc-4bfa-bcb2-fdc1828020bf.json

+                        "id": "",
+                        "params": {
+                            "fontSize": 12,
+                            "markdown": "**Navigation**\n\n**ServiceNow CMDB**\n\n- [Incident](#/dashboard/servicenow_cmdb-d929c3a1-7af8-428e-8357-8b2e8d3e3050)\n- [Problem](#/dashboard/servicenow_cmdb-d8977587-d9b4-4487-b321-a8402da07d48)\n- [Change Task and Request](#/dashboard/servicenow_cmdb-d2eb3f0c-4ddb-4683-afab-2820d2616ca2)\n- [User and Group](#/dashboard/servicenow_cmdb-b4795d3e-8c8b-48b2-900e-edc89db4d336)\n- [CMDB CI Servers](#/dashboard/servicenow_cmdb-22d413b7-ffb5-450f-b5f8-7dcd54fab22f)\n- [CMDB CI Services and CMN Location](#/dashboard/servicenow_cmdb-648308f9-ebdf-46fe-b6ce-b90dfcf2d1dd)\n- [CMDB CI, REL and DB Instance Overview](#/dashboard/servicenow_cmdb-0305f883-12a8-4021-af73-fbe05e797c3f)\n- [Knowledge](#/dashboard/servicenow_cmdb-e6093b0d-38a6-4b05-8354-4bbaef28b667)\n- [ALM and CMDB CI Hardware and Computer](#/dashboard/servicenow_cmdb-b182c6a6-3b4e-413f-899d-dd255b1a3623)\n- [Service Catalog](#/dashboard/servicenow_cmdb-488772bc-4ce5-48c6-9e8a-d948439dbf39)\n- [Business Application](#/dashboard/servicenow_cmdb-297414cc-3b65-40b1-b15b-e33cf676b3bf)\n- **ESX and Hyper-V Server (This Page)**\n\n**Overview**\n\nThis dashboard displays key statistics and visualizations for ESX and Hyper-V Server Table, including ESX server distribution by attestation status, connected state, hardware status, and power state, as well as highlighting top ESX server support groups and providing insights into Hyper-V server firewall status, pool names, and Windows hosts.\n\n[**Integrations Page**](/app/integrations/detail/servicenow_cmdb/overview)",


Suggested change

"markdown": "**Navigation**\n\n**ServiceNow CMDB**\n\n- [Incident](#/dashboard/servicenow_cmdb-d929c3a1-7af8-428e-8357-8b2e8d3e3050)\n- [Problem](#/dashboard/servicenow_cmdb-d8977587-d9b4-4487-b321-a8402da07d48)\n- [Change Task and Request](#/dashboard/servicenow_cmdb-d2eb3f0c-4ddb-4683-afab-2820d2616ca2)\n- [User and Group](#/dashboard/servicenow_cmdb-b4795d3e-8c8b-48b2-900e-edc89db4d336)\n- [CMDB CI Servers](#/dashboard/servicenow_cmdb-22d413b7-ffb5-450f-b5f8-7dcd54fab22f)\n- [CMDB CI Services and CMN Location](#/dashboard/servicenow_cmdb-648308f9-ebdf-46fe-b6ce-b90dfcf2d1dd)\n- [CMDB CI, REL and DB Instance Overview](#/dashboard/servicenow_cmdb-0305f883-12a8-4021-af73-fbe05e797c3f)\n- [Knowledge](#/dashboard/servicenow_cmdb-e6093b0d-38a6-4b05-8354-4bbaef28b667)\n- [ALM and CMDB CI Hardware and Computer](#/dashboard/servicenow_cmdb-b182c6a6-3b4e-413f-899d-dd255b1a3623)\n- [Service Catalog](#/dashboard/servicenow_cmdb-488772bc-4ce5-48c6-9e8a-d948439dbf39)\n- [Business Application](#/dashboard/servicenow_cmdb-297414cc-3b65-40b1-b15b-e33cf676b3bf)\n- **ESX and Hyper-V Server (This Page)**\n\n**Overview**\n\nThis dashboard displays key statistics and visualizations for ESX and Hyper-V Server Table, including ESX server distribution by attestation status, connected state, hardware status, and power state, as well as highlighting top ESX server support groups and providing insights into Hyper-V server firewall status, pool names, and Windows hosts.\n\n[**Integrations Page**](/app/integrations/detail/servicenow_cmdb/overview)",

"markdown": "**Navigation**\n\n**ServiceNow CMDB**\n\n- [Incident](#/dashboard/servicenow_cmdb-d929c3a1-7af8-428e-8357-8b2e8d3e3050)\n- [Problem](#/dashboard/servicenow_cmdb-d8977587-d9b4-4487-b321-a8402da07d48)\n- [Change Task and Request](#/dashboard/servicenow_cmdb-d2eb3f0c-4ddb-4683-afab-2820d2616ca2)\n- [User and Group](#/dashboard/servicenow_cmdb-b4795d3e-8c8b-48b2-900e-edc89db4d336)\n- [CMDB CI Servers](#/dashboard/servicenow_cmdb-22d413b7-ffb5-450f-b5f8-7dcd54fab22f)\n- [CMDB CI Services and CMN Location](#/dashboard/servicenow_cmdb-648308f9-ebdf-46fe-b6ce-b90dfcf2d1dd)\n- [CMDB CI, REL and DB Instance Overview](#/dashboard/servicenow_cmdb-0305f883-12a8-4021-af73-fbe05e797c3f)\n- [Knowledge](#/dashboard/servicenow_cmdb-e6093b0d-38a6-4b05-8354-4bbaef28b667)\n- [ALM and CMDB CI Hardware and Computer](#/dashboard/servicenow_cmdb-b182c6a6-3b4e-413f-899d-dd255b1a3623)\n- [Service Catalog](#/dashboard/servicenow_cmdb-488772bc-4ce5-48c6-9e8a-d948439dbf39)\n- [Business Application](#/dashboard/servicenow_cmdb-297414cc-3b65-40b1-b15b-e33cf676b3bf)\n- **ESX and Hyper-V Server**\n\n**Overview**\n\nThis dashboard displays key statistics and visualizations for ESX and Hyper-V Server Table, including ESX server distribution by attestation status, connected state, hardware status, and power state, as well as highlighting top ESX server support groups and providing insights into Hyper-V server firewall status, pool names, and Windows hosts.\n\n[**Integrations Page**](/app/integrations/detail/servicenow_cmdb/overview)",

Same change for the other pages.

efd6 · 2024-10-30T22:08:41Z

packages/servicenow_cmdb/data_stream/event/elasticsearch/ingest_pipeline/default.yml

+        ctx.servicenow_cmdb?.event?.table_name != null && (
+          ctx.servicenow_cmdb.event.table_name == 'cmdb' ||
+          ctx.servicenow_cmdb.event.table_name == 'cmdb_rel_ci'
+        ) || ctx.servicenow_cmdb?.event?.table_name.contains("cmdb_ci")


Why is this outside the parens?

efd6 · 2024-10-30T22:11:40Z

...cenow_cmdb/data_stream/event/elasticsearch/ingest_pipeline/pipeline_cmdb_ci_business_app.yml

+  - set:
+      field: event.kind
+      tag: set_pipeline_error_to_event_kind
+      value: pipeline_error


Final new line.

muskan-agarwal26 added 2 commits October 25, 2024 17:10

Initial release of ServiceNow CMDB

270948f

Updated changelog entry and codeowners

7c65193

kcreddy added Crest Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations] labels Oct 28, 2024

kcreddy added New Integration Integration:servicenow_cmdb [Integration not found in source] labels Oct 28, 2024

efd6 reviewed Oct 28, 2024

View reviewed changes

Resolve comments

c69361d

1. Implemented changes. 2. Added package inside codeowners.

muskan-agarwal26 requested a review from efd6 October 28, 2024 09:19

efd6 reviewed Oct 29, 2024

View reviewed changes

efd6 mentioned this pull request Oct 30, 2024

github: Add latest transforms for issues, dependabot, code_scanning, and secret_scanning alerts #11518

Merged

5 tasks

Resolving comments

775ffd3

1. Readme suggestions. 2. Changed the contains stmt in pipeline. 3. Added rule in config as suggested. 4. Removed the link of this page from dashboard. 5. Updated description for table_name in manifest.

muskan-agarwal26 requested a review from efd6 October 30, 2024 16:58

efd6 reviewed Oct 30, 2024

View reviewed changes

+                    - name: table_name
+                      type: text
+                      title: Table Name
+                      description: Table name to fetch logs for. Please enter the table name in lowercase with underscores. For example- cmdb_ci_infra_service for the Infrastructure Service table. Refer this [link](https://<your_instance_id>.service-now.com/now/nav/ui/classic/params/target/sys_db_object_list.do) for the exact table names.

+                    - name: table_name
+                      type: text
+                      title: Table Name
+                      description: Table name to fetch logs for. Please enter the table name in lowercase with underscores. For example- cmdb_ci_infra_service for the Infrastructure Service table. Refer this [link](https://<your_instance_id>.service-now.com/now/nav/ui/classic/params/target/sys_db_object_list.do) for the exact table names.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[servicenow_cmdb] Initial release of ServiceNow CMDB #11521

[servicenow_cmdb] Initial release of ServiceNow CMDB #11521

muskan-agarwal26 commented Oct 25, 2024

kcreddy commented Oct 28, 2024

elasticmachine commented Oct 28, 2024

efd6 left a comment

efd6 Oct 28, 2024

efd6 Oct 30, 2024

efd6 Oct 29, 2024

efd6 Oct 29, 2024

muskan-agarwal26 Oct 30, 2024

efd6 Oct 29, 2024

efd6 Oct 29, 2024

efd6 commented Oct 30, 2024

elastic-vault-github-plugin-prod bot commented Oct 30, 2024

elastic-sonarqube bot commented Oct 30, 2024

elasticmachine commented Oct 30, 2024

efd6 Oct 30, 2024

efd6 Oct 30, 2024

efd6 Oct 30, 2024

	- REST API mode: ServiceNow CMDB offers table APIs to retrieve data from its tables, the Elastic Agent polls these APIs to list their contents and read any new data. Visit this [link](https://developer.servicenow.com/dev.do#!/reference/api/washingtondc/rest/c_TableAPI#table-GET) for additional information about REST APIs.
	- REST API mode: ServiceNow CMDB offers table APIs to retrieve data from its tables; the Elastic Agent polls these APIs to list their contents and read any new data. Visit this [link](https://developer.servicenow.com/dev.do#!/reference/api/washingtondc/rest/c_TableAPI#table-GET) for additional information about REST APIs.

-      if: ctx.servicenow_cmdb?.event?.table_name != null && ['cmdb_ci_service','change_task','cmdb_rel_ci','cmdb_ci_infra_service','cmdb_ci','cmdb','cmdb_ci_vm','cmdb_ci_db_instance','cmdb_ci_appl','cmdb_ci_esx_server'].contains(ctx.servicenow_cmdb.event.table_name)
+      if: >-
+        ctx.servicenow_cmdb?.event?.table_name != null && (
+          ctx.servicenow_cmdb.event.table_name == 'cmdb_ci_service' ||
+          ctx.servicenow_cmdb.event.table_name == 'change_task' ||
+          ctx.servicenow_cmdb.event.table_name == 'cmdb_rel_ci' ||
+          ctx.servicenow_cmdb.event.table_name == 'cmdb_ci_infra_service' ||
+          ctx.servicenow_cmdb.event.table_name == 'cmdb_ci' ||
+          ctx.servicenow_cmdb.event.table_name == 'cmdb' ||
+          ctx.servicenow_cmdb.event.table_name == 'cmdb_ci_vm' ||
+          ctx.servicenow_cmdb.event.table_name == 'cmdb_ci_db_instance' ||
+          ctx.servicenow_cmdb.event.table_name == 'cmdb_ci_appl' ||
+          ctx.servicenow_cmdb.event.table_name == 'cmdb_ci_esx_server'
+        )

	description: URL of ServiceNow instance. It should follow the given format, https://<instance_id>.service-now.com.
	description: URL of ServiceNow instance. It should follow the given format, https://\<instance_id\>.service-now.com.

	description: Table name to fetch logs for. Please enter the table name in lowercase with underscores. For example- cmdb_ci_infra_service for the Infrastructure Service table. Refer this [link](https://<your_instance_id>.service-now.com/now/nav/ui/classic/params/target/sys_db_object_list.do) for the exact table names.
	description: Table name to fetch logs for. Please enter the table name in lowercase with underscores. For example, cmdb_ci_infra_service for the Infrastructure Service table. Refer this [link](https://<your_instance_id>.service-now.com/now/nav/ui/classic/params/target/sys_db_object_list.do) for the exact table names.

[servicenow_cmdb] Initial release of ServiceNow CMDB #11521

Are you sure you want to change the base?

[servicenow_cmdb] Initial release of ServiceNow CMDB #11521

Conversation

muskan-agarwal26 commented Oct 25, 2024

Proposed commit message

Checklist

How to test this PR locally

Screenshots

kcreddy commented Oct 28, 2024

elasticmachine commented Oct 28, 2024

efd6 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

efd6 commented Oct 30, 2024

elastic-vault-github-plugin-prod bot commented Oct 30, 2024

🚀 Benchmarks report

elastic-sonarqube bot commented Oct 30, 2024

Quality Gate passed

elasticmachine commented Oct 30, 2024

💚 Build Succeeded

History

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment