[Reporting] Functional test structure & improvements #114298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsullivan
changed the title
|
@elasticmachine merge upstream |
tsullivan
added
release_note:skip
|
Pinging @elastic/kibana-reporting-services (Team:Reporting Services) |
jbudz
approved these changes
Oct 12, 2021
|
@elasticmachine merge upstream |
jloleysens
approved these changes
Oct 14, 2021
There was a problem hiding this comment.
Changes look good, thanks for cleaning this up @tsullivan !
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: |
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Oct 14, 2021
* [Reporting] Functional test structure & improvements * show the error of the report generation failure in the test failure * update snapshot * remove import to non-existent functional app test Co-authored-by: Kibana Machine <[email protected]>
tsullivan
added a commit
that referenced
this pull request
Oct 14, 2021
* [Reporting] Functional test structure & improvements * show the error of the report generation failure in the test failure * update snapshot * remove import to non-existent functional app test Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
sophiec20
added
the
(Deprecated) Feature:Reporting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follows #110470 (comment)
Other changes:
x-pack/test/functional/apps/reportingbecause Reporting is not an app. The tests that were deleted already exist underx-pack/test/functional/apps/visualize