-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Visualize][Lens] Sync panels tooltips on dashboard level #130449
Conversation
Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors) |
@ppisljar I think it's fine for this PR but maybe we should think about another approach to handle this kind of options. We are looking into the direction of pulling more configuration options to the dashboard level (instead of having them defined per panel) and the current approach of how these options are passed through the layers doesn't scale well:
|
@flash1293 as I mention on the description for agg based, it works only for charts that have the Show detailed tooltip switch off. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK on agg based, that works as expected.
For timelion - I found the problem. It's happening because timelion does not respect the configured time zone and in my case it was producing different non-matching buckets. I will open a separate issue for that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I very much agree with @flash1293 that we need an easier way to store options like this at the dashboard level, but it'll likely be on us to get this all straightened out.
In the meantime, this is exactly the way adding a new option to the dashboard should be done. LGTM!
Code only review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
app services code LGTM
💚 Build SucceededMetrics [docs]Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
History
To update your PR or re-run it, just comment with: |
Summary
Closes #113719
This PR adds an extra option on the dashboard settings page. It is false by default. When it is enabled, all the panels that support it are synchronizing and the tooltip is displayed when the user hovers over a chart.
The feature is supported on:
Checklist
Delete any items that are not applicable to this PR.