fix Failing test: X-Pack Saved Object Tagging Functional Tests.x-pack/test/saved_object_tagging/functional/tests/dashboard_integration·ts - saved objects tagging - functional tests dashboard integration creating allows to select tags for a new dashboard #160687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/test/saved_object_tagging/functional/tests/dashboard_integration·ts - saved objects tagging - functional tests dashboard integration creating allows to select tags for a new dashboard
…-ref HEAD~1..HEAD --fix'
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: |
nreese
added
Team:Presentation
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
ThomThomson
approved these changes
Jun 28, 2023
There was a problem hiding this comment.
Thank you for the detailed explanation in #160583 (comment)
These changes LGTM, it's often better to check with the dom to drive changes in behaviour than to take a boolean as an argument!
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 28, 2023
…/test/saved_object_tagging/functional/tests/dashboard_integration·ts - saved objects tagging - functional tests dashboard integration creating allows to select tags for a new dashboard (elastic#160687) Closes elastic#160583 flaky test runner https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2513 Harden `dashboard_page.enterDashboardTitleAndClickSave` for retry loops so does not try to open save dialog when its already open from first save attempt failure. --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit ef7fda2)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jun 28, 2023
…x-pack/test/saved_object_tagging/functional/tests/dashboard_integration·ts - saved objects tagging - functional tests dashboard integration creating allows to select tags (#160782) # Backport This will backport the following commits from `main` to `8.9`: - [fix Failing test: X-Pack Saved Object Tagging Functional Tests.x-pack/test/saved_object_tagging/functional/tests/dashboard_integration·ts - saved objects tagging - functional tests dashboard integration creating allows to select tags for a new dashboard (#160687)](#160687) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nathan Reese","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-06-28T16:14:50Z","message":"fix Failing test: X-Pack Saved Object Tagging Functional Tests.x-pack/test/saved_object_tagging/functional/tests/dashboard_integration·ts - saved objects tagging - functional tests dashboard integration creating allows to select tags for a new dashboard (#160687)\n\nCloses https://github.com/elastic/kibana/issues/160583\r\n\r\nflaky test runner\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2513\r\n\r\nHarden `dashboard_page.enterDashboardTitleAndClickSave` for retry loops\r\nso does not try to open save dialog when its already open from first\r\nsave attempt failure.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"ef7fda2d249f47a86b8e930b577b47990fb334ad","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Presentation","release_note:skip","v8.9.0","v8.10.0"],"number":160687,"url":"https://github.com/elastic/kibana/pull/160687","mergeCommit":{"message":"fix Failing test: X-Pack Saved Object Tagging Functional Tests.x-pack/test/saved_object_tagging/functional/tests/dashboard_integration·ts - saved objects tagging - functional tests dashboard integration creating allows to select tags for a new dashboard (#160687)\n\nCloses https://github.com/elastic/kibana/issues/160583\r\n\r\nflaky test runner\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2513\r\n\r\nHarden `dashboard_page.enterDashboardTitleAndClickSave` for retry loops\r\nso does not try to open save dialog when its already open from first\r\nsave attempt failure.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"ef7fda2d249f47a86b8e930b577b47990fb334ad"}},"sourceBranch":"main","suggestedTargetBranches":["8.9"],"targetPullRequestStates":[{"branch":"8.9","label":"v8.9.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/160687","number":160687,"mergeCommit":{"message":"fix Failing test: X-Pack Saved Object Tagging Functional Tests.x-pack/test/saved_object_tagging/functional/tests/dashboard_integration·ts - saved objects tagging - functional tests dashboard integration creating allows to select tags for a new dashboard (#160687)\n\nCloses https://github.com/elastic/kibana/issues/160583\r\n\r\nflaky test runner\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2513\r\n\r\nHarden `dashboard_page.enterDashboardTitleAndClickSave` for retry loops\r\nso does not try to open save dialog when its already open from first\r\nsave attempt failure.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"ef7fda2d249f47a86b8e930b577b47990fb334ad"}}]}] BACKPORT--> Co-authored-by: Nathan Reese <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #160583
flaky test runner https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2513
Harden
dashboard_page.enterDashboardTitleAndClickSavefor retry loops so does not try to open save dialog when its already open from first save attempt failure.