Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Failing test: X-Pack Saved Object Tagging Functional Tests.x-pack/test/saved_object_tagging/functional/tests/dashboard_integration·ts - saved objects tagging - functional tests dashboard integration creating allows to select tags for a new dashboard #160687

Merged
merged 2 commits into from
Jun 28, 2023
Merged

fix Failing test: X-Pack Saved Object Tagging Functional Tests.x-pack/test/saved_object_tagging/functional/tests/dashboard_integration·ts - saved objects tagging - functional tests dashboard integration creating allows to select tags for a new dashboard #160687

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac12b89
fix Failing test: X-Pack Saved Object Tagging Functional Tests.x-pack…
nreese Jun 27, 2023
024c230
[CI] Auto-commit changed files from 'node scripts/precommit_hook.js -…
kibanamachine Jun 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions test/functional/page_objects/dashboard_page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,11 +472,10 @@ export class DashboardPageObject extends FtrService {
*/
public async saveDashboard(
dashboardName: string,
saveOptions: SaveDashboardOptions = { waitDialogIsClosed: true, exitFromEditMode: true },
clickMenuItem = true
saveOptions: SaveDashboardOptions = { waitDialogIsClosed: true, exitFromEditMode: true }
) {
await this.retry.try(async () => {
await this.enterDashboardTitleAndClickSave(dashboardName, saveOptions, clickMenuItem);
await this.enterDashboardTitleAndClickSave(dashboardName, saveOptions);

if (saveOptions.needsConfirm) {
await this.ensureDuplicateTitleCallout();
Expand Down Expand Up @@ -516,10 +515,12 @@ export class DashboardPageObject extends FtrService {
*/
public async enterDashboardTitleAndClickSave(
dashboardTitle: string,
saveOptions: SaveDashboardOptions = { waitDialogIsClosed: true },
clickMenuItem = true
saveOptions: SaveDashboardOptions = { waitDialogIsClosed: true }
) {
if (clickMenuItem) {
const isSaveModalOpen = await this.testSubjects.exists('savedObjectSaveModal', {
timeout: 2000,
});
if (!isSaveModalOpen) {
await this.testSubjects.click('dashboardSaveMenuItem');
}
const modalDialog = await this.testSubjects.find('savedObjectSaveModal');
Expand Down