[Security Solution][Notes] - add new notes icon for manage page #194752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilippeOberti
added
backport
release_note:skip
|
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
paul-tavares
approved these changes
Oct 2, 2024
PhilippeOberti
force-pushed
the
notes-icon
branch
from
16335e5
to
3c5b997
Compare
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
ashokaditya
approved these changes
Oct 3, 2024
| import React from 'react'; | ||
|
|
||
| export const IconNotes: React.FC<SVGProps<SVGSVGElement>> = ({ ...props }) => ( | ||
| <svg |
There was a problem hiding this comment.
If you do happen to use this SVG markup, I'd suggest you compress its size using https://svgomg.net/.
Here's the compressed version that saves up to 89 bytes but renders the same
<svg xmlns="http://www.w3.org/2000/svg" fill="none" viewBox="0 0 32 32" {...props}>
<path fill="#017D73" d="M15 13H6v2h9v-2Zm7 5H6v2h16v-2ZM6 23h16v2H6v-2Z"/>
<path fill="#343741" d="M19.41 0H3a3 3 0 0 0-3 3v26a3 3 0 0 0 3 3h22a3 3 0 0 0 3-3V8.59L19.41 0ZM20 3.41 24.59 8H20V3.41ZM25 30H3a1 1 0 0 1-1-1V3a1 1 0 0 1 1-1h15v8h8v19a1 1 0 0 1-1 1Z"/>
</svg>Settings I used with your markup to compress (precision 3, plus swithces)
|
@PhilippeOberti Thanks for mentioning. I think it's totally fine to use this icon. It refers more to document/notes metaphor. |
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 3, 2024
…tic#194752) (cherry picked from commit c3364db)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 3, 2024
…#194752) (#194844) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution][Notes] - add new notes icon for manage page (#194752)](#194752) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Philippe Oberti","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-03T14:01:21Z","message":"[Security Solution][Notes] - add new notes icon for manage page (#194752)","sha":"c3364db26c898316ce29e5ed09fb3be260cc66bc","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","release_note:skip","v9.0.0","Team:Threat Hunting:Investigations","v8.16.0"],"title":"[Security Solution][Notes] - add new notes icon for manage page","number":194752,"url":"https://github.com/elastic/kibana/pull/194752","mergeCommit":{"message":"[Security Solution][Notes] - add new notes icon for manage page (#194752)","sha":"c3364db26c898316ce29e5ed09fb3be260cc66bc"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194752","number":194752,"mergeCommit":{"message":"[Security Solution][Notes] - add new notes icon for manage page (#194752)","sha":"c3364db26c898316ce29e5ed09fb3be260cc66bc"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Philippe Oberti <[email protected]>
tiansivive
pushed a commit
to tiansivive/kibana
that referenced
this pull request
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is a follow up of this previous PR that added a new entry for the Notes management page to the Manage section (in the current/old navigation) and an entry to the Investigations section in the new space-specific Security navigation. That PR was using the already existing
IconFilebeatCharticon.The new notes icon was extracted from this mockThanks @paul-tavares for highlighting that EUI might have an icon for this already. Then indeed have. @ferenrigue @codearos are we ok using the same icon as fileBeat for notes? Should we create a different icon here?
#193059