Reapply "Revert org wide PR bot (#188771)" #194768
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2c8b2ff. We were seeing intermittent stuck status checks previously. There have been changes since that should alleviate the issue.
jbudz
added
Team:Operations
|
Pinging @elastic/kibana-operations (Team:Operations) |
Ikuni17
approved these changes
Oct 2, 2024
Closes elastic#187110 Closes elastic#187111 Closes elastic#153834 ## Summary This PR changes how we show source and alert status information, as shown below:  Also, for the APM Latency rule type, we now have a threshold component similar to other rules. For the SLO burn rate rule, the SLO link is added to the source list. |Rule type|Screenshot| |---|---| |APM Latency|| |SLO burn rate|| --------- Co-authored-by: kibanamachine <[email protected]>
## Summary Fixes elastic#194872 by adjusting the way the arch is determined
…elastic#194682) ## Summary Creates a pipeline for testing against `google-chrome-beta`. - Uses the flag: `USE_CHROME_BETA` to switch functional tests to running against chrome-beta. - Uses the same pipeline file PR builds are using - Only FTRs will be using `google-chrome-beta`, so other test types are disabled - [x] check if other test types (integration / cypress) can be directed to `google-chrome-beta`. Tested with the migration staging pipeline: https://buildkite.com/elastic/kibana-migration-pipeline-staging/builds/164 Connected to: elastic/kibana-operations#199
…lastic#194721) closes elastic#190895, elastic#190896, and elastic#190897 ## Summary > Sass's behavior for declarations that appear after nested rules will be changing to match the behavior specified by CSS in an upcoming version. To keep the existing behavior, move the declaration above the nested rule. To opt into the new behavior, wrap the declaration in & {}. PR moves declarations above the nested rules. Co-authored-by: Elastic Machine <[email protected]>
…lastic#194874) ## Summary Disable “Assign roles to space” button if no base privileges or features are selected **Before** https://github.com/user-attachments/assets/4efa921b-6cc4-4496-99f7-0ee79dd318be **After** https://github.com/user-attachments/assets/fc8fe809-f03a-4f0b-a961-328596c9b2c7 ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed
… QA (elastic#192885) ## Summary An override was used so far when a commit was provided no matter who/what/where the tests were running. With this change. the override will not be used when the quality gate runs in QA. The reason behind this change is that we want to simulate the customer's behavior, so we will be creating a project with whichever version is currently deployed in QA. --------- Co-authored-by: Domenico Andreoli <[email protected]>
## Summary Just fixing a couple checks in a serverless FT test. Made the same changes in elastic#193305 but forgot the serverless test. ### Checklist - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
jbudz
requested review from
a team,
MadameSheema,
patrykkopycinski,
maximpn and
banderror
as code owners
botelastic
bot
added
ci:project-deploy-observability
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
|
Sorry for the pings. |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Public APIs missing exports
Page load bundle
Unknown metric groupsAPI count
async chunk count
History
To update your PR or re-run it, just comment with: |
jbudz
added a commit
that referenced
this pull request
Oct 7, 2024
#194768 without the merge conflicts. Switches over to the org wide PR bot, with backwards compatibility for both versions. Updating the pipeline definition here is a global set for environment variables on all branches, so I intend on merging the backports first to support both versions and then proceeding with this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 2c8b2ff.
Switches this repository over to the global PR bot instead our version.
We were seeing intermittent stuck status checks previously. There have been changes since that should resolve that issue.