Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reapply "Revert org wide PR bot (#188771)" #194768

Closed
wants to merge 13 commits into from

Commits on Oct 2, 2024

  1. Reapply "Revert org wide PR bot (elastic#188771)"

    This reverts commit 2c8b2ff.
    
    We were seeing intermittent stuck status checks previously.  There have
    been changes since that should alleviate the issue.
    jbudz committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    6adbfed View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2024

  1. Configuration menu
    Copy the full SHA
    7cb45d9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ad8334b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9329c3e View commit details
    Browse the repository at this point in the history
  4. [Alert details page] Update source and status bar (elastic#194842)

    Closes elastic#187110
    Closes elastic#187111
    Closes elastic#153834
    
    ## Summary
    
    This PR changes how we show source and alert status information, as
    shown below:
    
    
    ![image](https://github.com/user-attachments/assets/7ab12e3a-f2e4-4bf8-8b47-955e2e1bb47f)
    
    Also, for the APM Latency rule type, we now have a threshold component
    similar to other rules. For the SLO burn rate rule, the SLO link is
    added to the source list.
    
    |Rule type|Screenshot|
    |---|---|
    |APM
    Latency|![image](https://github.com/user-attachments/assets/9846570a-46db-46a7-b3a0-96a1e63b58ad)|
    |SLO burn
    rate|![image](https://github.com/user-attachments/assets/e0042a8a-e1c0-4dc0-a909-73140e8a0b21)|
    
    ---------
    
    Co-authored-by: kibanamachine <[email protected]>
    2 people authored and jbudz committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    da7ec4d View commit details
    Browse the repository at this point in the history
  5. [Observability Onboarding] Fix Otel for x86_64 macs (elastic#194915)

    ## Summary
    
    Fixes elastic#194872 by adjusting the
    way the arch is determined
    flash1293 authored and jbudz committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    9125542 View commit details
    Browse the repository at this point in the history
  6. [ci] Create pipeline for chrome forward-testing against beta versions (

    …elastic#194682)
    
    ## Summary
    Creates a pipeline for testing against `google-chrome-beta`.
    
    - Uses the flag: `USE_CHROME_BETA` to switch functional tests to running
    against chrome-beta.
    - Uses the same pipeline file PR builds are using
    - Only FTRs will be using `google-chrome-beta`, so other test types are
    disabled
    - [x] check if other test types (integration / cypress) can be directed
    to `google-chrome-beta`.
      
      
    Tested with the migration staging pipeline:
    https://buildkite.com/elastic/kibana-migration-pipeline-staging/builds/164
    
    Connected to: elastic/kibana-operations#199
    delanni authored and jbudz committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    9ab465d View commit details
    Browse the repository at this point in the history
  7. [presentation team] Fix SASS mixed-declarations deprecation warnings (e…

    …lastic#194721)
    
    closes elastic#190895,
    elastic#190896, and
    elastic#190897
    
    ## Summary
    
    > Sass's behavior for declarations that appear after nested
    rules will be changing to match the behavior specified by CSS in an
    upcoming
    version. To keep the existing behavior, move the declaration above the
    nested
    rule. To opt into the new behavior, wrap the declaration in & {}.
    
    PR moves declarations above the nested rules.
    
    Co-authored-by: Elastic Machine <[email protected]>
    2 people authored and jbudz committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    4398984 View commit details
    Browse the repository at this point in the history
  8. Disable “Assign roles to space” button if no privileges are selected (e…

    …lastic#194874)
    
    ## Summary
    
    Disable “Assign roles to space” button if no base privileges or features
    are selected
    
    **Before**
    
    
    https://github.com/user-attachments/assets/4efa921b-6cc4-4496-99f7-0ee79dd318be
    
    **After**
    
    
    https://github.com/user-attachments/assets/fc8fe809-f03a-4f0b-a961-328596c9b2c7
    
    ### Checklist
    
    Delete any items that are not applicable to this PR.
    
    - [x] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    - [x] [Flaky Test
    Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
    used on any tests changed
    tsullivan authored and jbudz committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    68af486 View commit details
    Browse the repository at this point in the history
  9. [Security][Serverless] Removed override when the quality gate runs in…

    … QA (elastic#192885)
    
    ## Summary
    
    An override was used so far when a commit was provided no matter
    who/what/where the tests were running.
    
    With this change. the override will not be used when the quality gate
    runs in QA. The reason behind this change is that we want to simulate
    the customer's behavior, so we will be creating a project with whichever
    version is currently deployed in QA.
    
    ---------
    
    Co-authored-by: Domenico Andreoli <[email protected]>
    2 people authored and jbudz committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    1be6d98 View commit details
    Browse the repository at this point in the history
  10. [Discover] Fix checks in serverless functional test (elastic#194881)

    ## Summary
    
    Just fixing a couple checks in a serverless FT test. Made the same
    changes in elastic#193305 but forgot the serverless test.
    
    ### Checklist
    
    - [ ] Any text added follows [EUI's writing
    guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
    sentence case text and includes [i18n
    support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
    - [ ]
    [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
    was added for features that require explanation or tutorials
    - [x] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    - [ ] [Flaky Test
    Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
    used on any tests changed
    - [ ] Any UI touched in this PR is usable by keyboard only (learn more
    about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
    - [ ] Any UI touched in this PR does not create any new axe failures
    (run axe in browser:
    [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
    [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
    - [ ] If a plugin configuration key changed, check if it needs to be
    allowlisted in the cloud and added to the [docker
    list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
    - [ ] This renders correctly on smaller devices using a responsive
    layout. (You can test this [in your
    browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
    - [ ] This was checked for [cross-browser
    compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
    
    ### For maintainers
    
    - [ ] This was checked for breaking API changes and was [labeled
    appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
    davismcphee authored and jbudz committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    e4499b1 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    0c75a10 View commit details
    Browse the repository at this point in the history
  12. backwards compatibility

    jbudz committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    c800856 View commit details
    Browse the repository at this point in the history