-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EDR Workflows] Unskip osquery tests #196793
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomsonpl
added
release_note:skip
Skip the PR/issue when compiling release notes
Team:Defend Workflows
“EDR Workflows” sub-team of Security Solution
v8.16.0
backport:version
Backport to applied version labels
labels
Oct 18, 2024
/ci |
/ci |
/ci |
…ip-osquery-test-1
/ci |
szwarckonrad
approved these changes
Oct 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add description explaining what was done to unskip those. Thanks!
Starting backport for target branches: 8.16, 8.x |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
cc @tomsonpl |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 21, 2024
(cherry picked from commit 2c25cc0)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 21, 2024
(cherry picked from commit 2c25cc0)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 21, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[EDR Workflows] Unskip osquery tests (#196793)](#196793) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Tomasz Ciecierski","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-21T18:50:12Z","message":"[EDR Workflows] Unskip osquery tests (#196793)","sha":"2c25cc06588976cb90ec3551320fef3e8dbbecf4","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Defend Workflows","v8.16.0","backport:version","v8.17.0"],"title":"[EDR Workflows] Unskip osquery tests","number":196793,"url":"https://github.com/elastic/kibana/pull/196793","mergeCommit":{"message":"[EDR Workflows] Unskip osquery tests (#196793)","sha":"2c25cc06588976cb90ec3551320fef3e8dbbecf4"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196793","number":196793,"mergeCommit":{"message":"[EDR Workflows] Unskip osquery tests (#196793)","sha":"2c25cc06588976cb90ec3551320fef3e8dbbecf4"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Tomasz Ciecierski <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Oct 21, 2024
# Backport This will backport the following commits from `main` to `8.16`: - [[EDR Workflows] Unskip osquery tests (#196793)](#196793) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Tomasz Ciecierski","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-21T18:50:12Z","message":"[EDR Workflows] Unskip osquery tests (#196793)","sha":"2c25cc06588976cb90ec3551320fef3e8dbbecf4","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Defend Workflows","v8.16.0","backport:version","v8.17.0"],"title":"[EDR Workflows] Unskip osquery tests","number":196793,"url":"https://github.com/elastic/kibana/pull/196793","mergeCommit":{"message":"[EDR Workflows] Unskip osquery tests (#196793)","sha":"2c25cc06588976cb90ec3551320fef3e8dbbecf4"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196793","number":196793,"mergeCommit":{"message":"[EDR Workflows] Unskip osquery tests (#196793)","sha":"2c25cc06588976cb90ec3551320fef3e8dbbecf4"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Tomasz Ciecierski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:version
Backport to applied version labels
release_note:skip
Skip the PR/issue when compiling release notes
Team:Defend Workflows
“EDR Workflows” sub-team of Security Solution
v8.16.0
v8.17.0
v9.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR unskips the tests that were skipped due to a recent Serverless <> Fleet issue and EUI changes introduced while the tests were skipped.