Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EDR Workflows] Unskip osquery tests #196793

Merged
merged 9 commits into from
Oct 21, 2024

Conversation

tomsonpl
Copy link
Contributor

@tomsonpl tomsonpl commented Oct 18, 2024

This PR unskips the tests that were skipped due to a recent Serverless <> Fleet issue and EUI changes introduced while the tests were skipped.

@tomsonpl tomsonpl added release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.16.0 backport:version Backport to applied version labels labels Oct 18, 2024
@tomsonpl tomsonpl self-assigned this Oct 18, 2024
@tomsonpl
Copy link
Contributor Author

/ci

@tomsonpl
Copy link
Contributor Author

/ci

@tomsonpl
Copy link
Contributor Author

/ci

@tomsonpl
Copy link
Contributor Author

/ci

@tomsonpl tomsonpl marked this pull request as ready for review October 21, 2024 11:20
@tomsonpl tomsonpl requested a review from a team as a code owner October 21, 2024 11:20
Copy link
Contributor

@szwarckonrad szwarckonrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add description explaining what was done to unskip those. Thanks!

@tomsonpl tomsonpl enabled auto-merge (squash) October 21, 2024 12:27
@tomsonpl tomsonpl merged commit 2c25cc0 into elastic:main Oct 21, 2024
44 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.16, 8.x

https://github.com/elastic/kibana/actions/runs/11446669538

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #103 / serverless observability UI Dataset Quality Dataset quality details navigate to dataset details should navigate to details page from a main page

Metrics [docs]

✅ unchanged

History

cc @tomsonpl

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 21, 2024
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 21, 2024
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.16
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 21, 2024
# Backport

This will backport the following commits from `main` to `8.x`:
- [[EDR Workflows] Unskip osquery tests
(#196793)](#196793)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Tomasz
Ciecierski","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-21T18:50:12Z","message":"[EDR
Workflows] Unskip osquery tests
(#196793)","sha":"2c25cc06588976cb90ec3551320fef3e8dbbecf4","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Defend
Workflows","v8.16.0","backport:version","v8.17.0"],"title":"[EDR
Workflows] Unskip osquery
tests","number":196793,"url":"https://github.com/elastic/kibana/pull/196793","mergeCommit":{"message":"[EDR
Workflows] Unskip osquery tests
(#196793)","sha":"2c25cc06588976cb90ec3551320fef3e8dbbecf4"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196793","number":196793,"mergeCommit":{"message":"[EDR
Workflows] Unskip osquery tests
(#196793)","sha":"2c25cc06588976cb90ec3551320fef3e8dbbecf4"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Tomasz Ciecierski <[email protected]>
kibanamachine added a commit that referenced this pull request Oct 21, 2024
# Backport

This will backport the following commits from `main` to `8.16`:
- [[EDR Workflows] Unskip osquery tests
(#196793)](#196793)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Tomasz
Ciecierski","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-21T18:50:12Z","message":"[EDR
Workflows] Unskip osquery tests
(#196793)","sha":"2c25cc06588976cb90ec3551320fef3e8dbbecf4","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Defend
Workflows","v8.16.0","backport:version","v8.17.0"],"title":"[EDR
Workflows] Unskip osquery
tests","number":196793,"url":"https://github.com/elastic/kibana/pull/196793","mergeCommit":{"message":"[EDR
Workflows] Unskip osquery tests
(#196793)","sha":"2c25cc06588976cb90ec3551320fef3e8dbbecf4"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196793","number":196793,"mergeCommit":{"message":"[EDR
Workflows] Unskip osquery tests
(#196793)","sha":"2c25cc06588976cb90ec3551320fef3e8dbbecf4"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Tomasz Ciecierski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.16.0 v8.17.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants