Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EDR Workflows] Unskip osquery tests #196793

Merged
merged 9 commits into from
Oct 21, 2024
Merged

[EDR Workflows] Unskip osquery tests #196793

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a1437b5
unskip tests, update artifact version
tomsonpl Oct 18, 2024
b71ccb7
Merge branch 'main' into unskip-osquery-test-1
tomsonpl Oct 18, 2024
ba3af78
Merge branch 'main' into unskip-osquery-test-1
tomsonpl Oct 18, 2024
409f231
fix
tomsonpl Oct 21, 2024
980f6cc
Merge remote-tracking branch 'origin/unskip-osquery-test-1' into unsk…
tomsonpl Oct 21, 2024
3adf040
Merge branch 'main' into unskip-osquery-test-1
tomsonpl Oct 21, 2024
b8e7df0
increase timeout
tomsonpl Oct 21, 2024
e44f086
Merge remote-tracking branch 'origin/unskip-osquery-test-1' into unsk…
tomsonpl Oct 21, 2024
f2cf035
move intiializeDataViews to before each
tomsonpl Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions x-pack/plugins/osquery/cypress/e2e/all/alerts_automated_action_results.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,7 @@ import { checkActionItemsInResults, loadRuleAlerts } from '../../tasks/live_quer

const UUID_REGEX = '[0-9A-Fa-f]{8}-[0-9A-Fa-f]{4}-[0-9A-Fa-f]{4}-[0-9A-Fa-f]{4}-[0-9A-Fa-f]{12}';

// Failing: See https://github.com/elastic/kibana/issues/178404
describe.skip('Alert Flyout Automated Action Results', () => {
describe('Alert Flyout Automated Action Results', () => {
let ruleId: string;

before(() => {
Expand Down
3 changes: 1 addition & 2 deletions x-pack/plugins/osquery/cypress/e2e/all/alerts_cases.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,7 @@ describe('Alert Event Details - Cases', { tags: ['@ess', '@serverless'] }, () =>
});
});

// FLAKY: https://github.com/elastic/kibana/issues/187182
describe.skip('Case', () => {
describe('Case', () => {
let caseId: string;

beforeEach(() => {
Expand Down
4 changes: 1 addition & 3 deletions x-pack/plugins/osquery/cypress/e2e/all/alerts_linked_apps.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,8 @@ describe(
() => {
let ruleId: string;
let ruleName: string;
before(() => {
initializeDataViews();
});
beforeEach(() => {
initializeDataViews();
loadRule().then((data) => {
ruleId = data.id;
ruleName = data.name;
Expand Down
3 changes: 1 addition & 2 deletions x-pack/plugins/osquery/cypress/e2e/all/live_query.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@ import { LIVE_QUERY_EDITOR } from '../../screens/live_query';
import { getAdvancedButton } from '../../screens/integrations';
import { ServerlessRoleName } from '../../support/roles';

// Failing: See https://github.com/elastic/kibana/issues/171435
describe.skip('ALL - Live Query', { tags: ['@ess', '@serverless'] }, () => {
describe('ALL - Live Query', { tags: ['@ess', '@serverless'] }, () => {
beforeEach(() => {
cy.login(ServerlessRoleName.SOC_MANAGER);
navigateTo('/app/osquery');
Expand Down
3 changes: 1 addition & 2 deletions x-pack/plugins/osquery/cypress/e2e/all/live_query_run.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,7 @@ import { getAdvancedButton } from '../../screens/integrations';
import { loadSavedQuery, cleanupSavedQuery } from '../../tasks/api_fixtures';
import { ServerlessRoleName } from '../../support/roles';

// FLAKY: https://github.com/elastic/kibana/issues/195458
describe.skip('ALL - Live Query run custom and saved', { tags: ['@ess', '@serverless'] }, () => {
describe('ALL - Live Query run custom and saved', { tags: ['@ess', '@serverless'] }, () => {
let savedQueryId: string;
let savedQueryName: string;

Expand Down
3 changes: 1 addition & 2 deletions x-pack/plugins/osquery/cypress/e2e/all/packs_create_edit.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,7 @@ import { loadSavedQuery, cleanupSavedQuery, cleanupPack, loadPack } from '../../
import { request } from '../../tasks/common';
import { ServerlessRoleName } from '../../support/roles';

// Failing: See https://github.com/elastic/kibana/issues/195463
describe.skip('Packs - Create and Edit', { tags: ['@ess', '@serverless'] }, () => {
describe('Packs - Create and Edit', { tags: ['@ess', '@serverless'] }, () => {
let savedQueryId: string;
let savedQueryName: string;
let nomappingSavedQueryId: string;
Expand Down
18 changes: 7 additions & 11 deletions x-pack/plugins/osquery/cypress/e2e/all/saved_queries.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,7 @@ import {
import { ServerlessRoleName } from '../../support/roles';
import { getAdvancedButton } from '../../screens/integrations';

// Failing: See https://github.com/elastic/kibana/issues/195453
// Failing: See https://github.com/elastic/kibana/issues/195453
describe.skip('ALL - Saved queries', { tags: ['@ess', '@serverless'] }, () => {
describe('ALL - Saved queries', { tags: ['@ess', '@serverless'] }, () => {
let caseId: string;

before(() => {
Expand Down Expand Up @@ -94,20 +92,18 @@ describe.skip('ALL - Saved queries', { tags: ['@ess', '@serverless'] }, () => {
cy.getBySel(RESULTS_TABLE_COLUMNS_BUTTON).should('have.text', 'Columns35');
cy.getBySel('dataGridColumnSelectorButton').click();
cy.get('[data-popover-open="true"]').should('be.visible');
cy.getBySel('dataGridColumnSelectorToggleColumnVisibility-osquery.cmdline').click();
cy.getBySel('dataGridColumnSelectorToggleColumnVisibility-osquery.cwd').click();
cy.getBySel(
'dataGridColumnSelectorToggleColumnVisibility-osquery.disk_bytes_written.number'
).click();
cy.getBySel('dataGridColumnSelectorColumnItem-osquery.cmdline').click();
cy.getBySel('dataGridColumnSelectorColumnItem-osquery.cwd').click();
cy.getBySel('dataGridColumnSelectorColumnItem-osquery.disk_bytes_written.number').click();
cy.getBySel('dataGridColumnSelectorButton').click();
cy.get('[data-popover-open="true"]').should('not.exist');
cy.getBySel(RESULTS_TABLE_COLUMNS_BUTTON).should('have.text', 'Columns32/35');
cy.getBySel(RESULTS_TABLE_COLUMNS_BUTTON).should('have.text', 'Columns35');

// change pagination
cy.getBySel('pagination-button-next').click();
cy.getBySel('globalLoadingIndicator').should('not.exist');
cy.getBySel('pagination-button-next').click();
cy.getBySel(RESULTS_TABLE_COLUMNS_BUTTON).should('have.text', 'Columns32/35');
cy.getBySel(RESULTS_TABLE_COLUMNS_BUTTON).should('have.text', 'Columns35');

// enter fullscreen
cy.getBySel(RESULTS_TABLE_BUTTON).trigger('mouseover');
Expand All @@ -118,7 +114,7 @@ describe.skip('ALL - Saved queries', { tags: ['@ess', '@serverless'] }, () => {
// sorting
cy.getBySel('dataGridHeaderCellActionButton-osquery.egid').click({ force: true });
cy.contains(/Sort A-Z$/).click();
cy.getBySel(RESULTS_TABLE_COLUMNS_BUTTON).should('have.text', 'Columns32/35');
cy.getBySel(RESULTS_TABLE_COLUMNS_BUTTON).should('have.text', 'Columns35');
cy.getBySel(RESULTS_TABLE_BUTTON).trigger('mouseover');
cy.contains(/Enter fullscreen$/).should('exist');

Expand Down
2 changes: 1 addition & 1 deletion x-pack/test/osquery_cypress/artifact_manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,5 @@
*/

export async function getLatestVersion(): Promise<string> {
return '8.11.0-SNAPSHOT';
return '8.15.0-SNAPSHOT';
}
2 changes: 1 addition & 1 deletion x-pack/test/security_solution_cypress/cypress/tasks/create_new_rule.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -884,7 +884,7 @@ export const waitForAlertsToPopulate = (alertCountThreshold = 1) => {
return alertCount >= alertCountThreshold;
});
},
{ interval: 500, timeout: 12000 }
{ interval: 500, timeout: 30000 }
);
waitForAlerts();
};
Expand Down