-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ingest Pipelines] Update copy in Manage processors #196923
Conversation
Pinging @elastic/kibana-management (Team:Kibana Management) |
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
cc @ElenaStoeva |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Starting backport for target branches: 8.x |
## Summary This PR adds some copy changes to the Manage processors pages. 1. Empty prompt - Width and padding of the prompt is adjusted so that "IP" in the title starts in the 2nd line - Description is updated <img width="800" alt="Screenshot 2024-10-18 at 17 00 53" src="https://github.com/user-attachments/assets/51aa6cdc-5eb4-4c54-8960-7ee273d82ef5"> 2. Add database modal - Copy in callouts is updated - The help text of the "Type" field is updated - The text in the "Database already exists" error callout is updated <img width="1490" alt="Screenshot 2024-10-21 at 09 34 12" src="https://github.com/user-attachments/assets/ab3c2e21-4457-435f-a4c3-874c6edcb2ce"> <img width="1498" alt="Screenshot 2024-10-18 at 17 24 43" src="https://github.com/user-attachments/assets/a0c15f5d-9360-4ee7-806d-2b5b64b6fd2a"> 3. Manage processors page - The title of the page is changed from "GeoIP" to "IP Location" <img width="800" alt="Screenshot 2024-10-18 at 17 20 01" src="https://github.com/user-attachments/assets/cde8b070-9664-42df-b71a-723a5356d4a2"> (cherry picked from commit 996eb73)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
## Summary This PR adds some copy changes to the Manage processors pages. 1. Empty prompt - Width and padding of the prompt is adjusted so that "IP" in the title starts in the 2nd line - Description is updated <img width="800" alt="Screenshot 2024-10-18 at 17 00 53" src="https://github.com/user-attachments/assets/51aa6cdc-5eb4-4c54-8960-7ee273d82ef5"> 2. Add database modal - Copy in callouts is updated - The help text of the "Type" field is updated - The text in the "Database already exists" error callout is updated <img width="1490" alt="Screenshot 2024-10-21 at 09 34 12" src="https://github.com/user-attachments/assets/ab3c2e21-4457-435f-a4c3-874c6edcb2ce"> <img width="1498" alt="Screenshot 2024-10-18 at 17 24 43" src="https://github.com/user-attachments/assets/a0c15f5d-9360-4ee7-806d-2b5b64b6fd2a"> 3. Manage processors page - The title of the page is changed from "GeoIP" to "IP Location" <img width="800" alt="Screenshot 2024-10-18 at 17 20 01" src="https://github.com/user-attachments/assets/cde8b070-9664-42df-b71a-723a5356d4a2"> (cherry picked from commit 996eb73)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…197187) # Backport This will backport the following commits from `main` to `8.x`: - [[Ingest Pipelines] Update copy in Manage processors (#196923)](#196923) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Elena Stoeva","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-22T09:14:42Z","message":"[Ingest Pipelines] Update copy in Manage processors (#196923)\n\n## Summary\r\n\r\nThis PR adds some copy changes to the Manage processors pages.\r\n\r\n1. Empty prompt\r\n- Width and padding of the prompt is adjusted so that \"IP\" in the title\r\nstarts in the 2nd line\r\n- Description is updated\r\n<img width=\"800\" alt=\"Screenshot 2024-10-18 at 17 00 53\"\r\nsrc=\"https://github.com/user-attachments/assets/51aa6cdc-5eb4-4c54-8960-7ee273d82ef5\">\r\n\r\n\r\n2. Add database modal\r\n- Copy in callouts is updated\r\n- The help text of the \"Type\" field is updated\r\n- The text in the \"Database already exists\" error callout is updated\r\n<img width=\"1490\" alt=\"Screenshot 2024-10-21 at 09 34 12\"\r\nsrc=\"https://github.com/user-attachments/assets/ab3c2e21-4457-435f-a4c3-874c6edcb2ce\">\r\n<img width=\"1498\" alt=\"Screenshot 2024-10-18 at 17 24 43\"\r\nsrc=\"https://github.com/user-attachments/assets/a0c15f5d-9360-4ee7-806d-2b5b64b6fd2a\">\r\n\r\n\r\n3. Manage processors page\r\n- The title of the page is changed from \"GeoIP\" to \"IP Location\"\r\n<img width=\"800\" alt=\"Screenshot 2024-10-18 at 17 20 01\"\r\nsrc=\"https://github.com/user-attachments/assets/cde8b070-9664-42df-b71a-723a5356d4a2\">","sha":"996eb73811c665945f8c4425d1e8e89fa9688b40","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Kibana Management","release_note:skip","v9.0.0","Feature:Ingest Node Pipelines","backport:prev-minor"],"title":"[Ingest Pipelines] Update copy in Manage processors","number":196923,"url":"https://github.com/elastic/kibana/pull/196923","mergeCommit":{"message":"[Ingest Pipelines] Update copy in Manage processors (#196923)\n\n## Summary\r\n\r\nThis PR adds some copy changes to the Manage processors pages.\r\n\r\n1. Empty prompt\r\n- Width and padding of the prompt is adjusted so that \"IP\" in the title\r\nstarts in the 2nd line\r\n- Description is updated\r\n<img width=\"800\" alt=\"Screenshot 2024-10-18 at 17 00 53\"\r\nsrc=\"https://github.com/user-attachments/assets/51aa6cdc-5eb4-4c54-8960-7ee273d82ef5\">\r\n\r\n\r\n2. Add database modal\r\n- Copy in callouts is updated\r\n- The help text of the \"Type\" field is updated\r\n- The text in the \"Database already exists\" error callout is updated\r\n<img width=\"1490\" alt=\"Screenshot 2024-10-21 at 09 34 12\"\r\nsrc=\"https://github.com/user-attachments/assets/ab3c2e21-4457-435f-a4c3-874c6edcb2ce\">\r\n<img width=\"1498\" alt=\"Screenshot 2024-10-18 at 17 24 43\"\r\nsrc=\"https://github.com/user-attachments/assets/a0c15f5d-9360-4ee7-806d-2b5b64b6fd2a\">\r\n\r\n\r\n3. Manage processors page\r\n- The title of the page is changed from \"GeoIP\" to \"IP Location\"\r\n<img width=\"800\" alt=\"Screenshot 2024-10-18 at 17 20 01\"\r\nsrc=\"https://github.com/user-attachments/assets/cde8b070-9664-42df-b71a-723a5356d4a2\">","sha":"996eb73811c665945f8c4425d1e8e89fa9688b40"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196923","number":196923,"mergeCommit":{"message":"[Ingest Pipelines] Update copy in Manage processors (#196923)\n\n## Summary\r\n\r\nThis PR adds some copy changes to the Manage processors pages.\r\n\r\n1. Empty prompt\r\n- Width and padding of the prompt is adjusted so that \"IP\" in the title\r\nstarts in the 2nd line\r\n- Description is updated\r\n<img width=\"800\" alt=\"Screenshot 2024-10-18 at 17 00 53\"\r\nsrc=\"https://github.com/user-attachments/assets/51aa6cdc-5eb4-4c54-8960-7ee273d82ef5\">\r\n\r\n\r\n2. Add database modal\r\n- Copy in callouts is updated\r\n- The help text of the \"Type\" field is updated\r\n- The text in the \"Database already exists\" error callout is updated\r\n<img width=\"1490\" alt=\"Screenshot 2024-10-21 at 09 34 12\"\r\nsrc=\"https://github.com/user-attachments/assets/ab3c2e21-4457-435f-a4c3-874c6edcb2ce\">\r\n<img width=\"1498\" alt=\"Screenshot 2024-10-18 at 17 24 43\"\r\nsrc=\"https://github.com/user-attachments/assets/a0c15f5d-9360-4ee7-806d-2b5b64b6fd2a\">\r\n\r\n\r\n3. Manage processors page\r\n- The title of the page is changed from \"GeoIP\" to \"IP Location\"\r\n<img width=\"800\" alt=\"Screenshot 2024-10-18 at 17 20 01\"\r\nsrc=\"https://github.com/user-attachments/assets/cde8b070-9664-42df-b71a-723a5356d4a2\">","sha":"996eb73811c665945f8c4425d1e8e89fa9688b40"}}]}] BACKPORT--> Co-authored-by: Elena Stoeva <[email protected]>
…197196) # Backport This will backport the following commits from `main` to `8.16`: - [[Ingest Pipelines] Update copy in Manage processors (#196923)](#196923) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Elena Stoeva","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-22T09:14:42Z","message":"[Ingest Pipelines] Update copy in Manage processors (#196923)\n\n## Summary\r\n\r\nThis PR adds some copy changes to the Manage processors pages.\r\n\r\n1. Empty prompt\r\n- Width and padding of the prompt is adjusted so that \"IP\" in the title\r\nstarts in the 2nd line\r\n- Description is updated\r\n<img width=\"800\" alt=\"Screenshot 2024-10-18 at 17 00 53\"\r\nsrc=\"https://github.com/user-attachments/assets/51aa6cdc-5eb4-4c54-8960-7ee273d82ef5\">\r\n\r\n\r\n2. Add database modal\r\n- Copy in callouts is updated\r\n- The help text of the \"Type\" field is updated\r\n- The text in the \"Database already exists\" error callout is updated\r\n<img width=\"1490\" alt=\"Screenshot 2024-10-21 at 09 34 12\"\r\nsrc=\"https://github.com/user-attachments/assets/ab3c2e21-4457-435f-a4c3-874c6edcb2ce\">\r\n<img width=\"1498\" alt=\"Screenshot 2024-10-18 at 17 24 43\"\r\nsrc=\"https://github.com/user-attachments/assets/a0c15f5d-9360-4ee7-806d-2b5b64b6fd2a\">\r\n\r\n\r\n3. Manage processors page\r\n- The title of the page is changed from \"GeoIP\" to \"IP Location\"\r\n<img width=\"800\" alt=\"Screenshot 2024-10-18 at 17 20 01\"\r\nsrc=\"https://github.com/user-attachments/assets/cde8b070-9664-42df-b71a-723a5356d4a2\">","sha":"996eb73811c665945f8c4425d1e8e89fa9688b40","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Kibana Management","release_note:skip","v9.0.0","Feature:Ingest Node Pipelines","backport:prev-minor","v8.16.0","v8.17.0"],"number":196923,"url":"https://github.com/elastic/kibana/pull/196923","mergeCommit":{"message":"[Ingest Pipelines] Update copy in Manage processors (#196923)\n\n## Summary\r\n\r\nThis PR adds some copy changes to the Manage processors pages.\r\n\r\n1. Empty prompt\r\n- Width and padding of the prompt is adjusted so that \"IP\" in the title\r\nstarts in the 2nd line\r\n- Description is updated\r\n<img width=\"800\" alt=\"Screenshot 2024-10-18 at 17 00 53\"\r\nsrc=\"https://github.com/user-attachments/assets/51aa6cdc-5eb4-4c54-8960-7ee273d82ef5\">\r\n\r\n\r\n2. Add database modal\r\n- Copy in callouts is updated\r\n- The help text of the \"Type\" field is updated\r\n- The text in the \"Database already exists\" error callout is updated\r\n<img width=\"1490\" alt=\"Screenshot 2024-10-21 at 09 34 12\"\r\nsrc=\"https://github.com/user-attachments/assets/ab3c2e21-4457-435f-a4c3-874c6edcb2ce\">\r\n<img width=\"1498\" alt=\"Screenshot 2024-10-18 at 17 24 43\"\r\nsrc=\"https://github.com/user-attachments/assets/a0c15f5d-9360-4ee7-806d-2b5b64b6fd2a\">\r\n\r\n\r\n3. Manage processors page\r\n- The title of the page is changed from \"GeoIP\" to \"IP Location\"\r\n<img width=\"800\" alt=\"Screenshot 2024-10-18 at 17 20 01\"\r\nsrc=\"https://github.com/user-attachments/assets/cde8b070-9664-42df-b71a-723a5356d4a2\">","sha":"996eb73811c665945f8c4425d1e8e89fa9688b40"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196923","number":196923,"mergeCommit":{"message":"[Ingest Pipelines] Update copy in Manage processors (#196923)\n\n## Summary\r\n\r\nThis PR adds some copy changes to the Manage processors pages.\r\n\r\n1. Empty prompt\r\n- Width and padding of the prompt is adjusted so that \"IP\" in the title\r\nstarts in the 2nd line\r\n- Description is updated\r\n<img width=\"800\" alt=\"Screenshot 2024-10-18 at 17 00 53\"\r\nsrc=\"https://github.com/user-attachments/assets/51aa6cdc-5eb4-4c54-8960-7ee273d82ef5\">\r\n\r\n\r\n2. Add database modal\r\n- Copy in callouts is updated\r\n- The help text of the \"Type\" field is updated\r\n- The text in the \"Database already exists\" error callout is updated\r\n<img width=\"1490\" alt=\"Screenshot 2024-10-21 at 09 34 12\"\r\nsrc=\"https://github.com/user-attachments/assets/ab3c2e21-4457-435f-a4c3-874c6edcb2ce\">\r\n<img width=\"1498\" alt=\"Screenshot 2024-10-18 at 17 24 43\"\r\nsrc=\"https://github.com/user-attachments/assets/a0c15f5d-9360-4ee7-806d-2b5b64b6fd2a\">\r\n\r\n\r\n3. Manage processors page\r\n- The title of the page is changed from \"GeoIP\" to \"IP Location\"\r\n<img width=\"800\" alt=\"Screenshot 2024-10-18 at 17 20 01\"\r\nsrc=\"https://github.com/user-attachments/assets/cde8b070-9664-42df-b71a-723a5356d4a2\">","sha":"996eb73811c665945f8c4425d1e8e89fa9688b40"}},{"branch":"8.16","label":"v8.16.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","labelRegex":"^v8.17.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/197187","number":197187,"state":"OPEN"}]}] BACKPORT-->
Summary
This PR adds some copy changes to the Manage processors pages.