Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ingest Pipelines] Update copy in Manage processors #196923

Merged
merged 3 commits into from
Oct 22, 2024

Conversation

ElenaStoeva
Copy link
Contributor

@ElenaStoeva ElenaStoeva commented Oct 18, 2024

Summary

This PR adds some copy changes to the Manage processors pages.

  1. Empty prompt
  • Width and padding of the prompt is adjusted so that "IP" in the title starts in the 2nd line
  • Description is updated
Screenshot 2024-10-18 at 17 00 53
  1. Add database modal
  • Copy in callouts is updated
  • The help text of the "Type" field is updated
  • The text in the "Database already exists" error callout is updated
Screenshot 2024-10-21 at 09 34 12 Screenshot 2024-10-18 at 17 24 43
  1. Manage processors page
  • The title of the page is changed from "GeoIP" to "IP Location"
Screenshot 2024-10-18 at 17 20 01

@ElenaStoeva ElenaStoeva added Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes Feature:Ingest Node Pipelines Ingest node pipelines management backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Oct 18, 2024
@ElenaStoeva ElenaStoeva self-assigned this Oct 18, 2024
@ElenaStoeva ElenaStoeva requested a review from a team as a code owner October 18, 2024 16:23
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
ingestPipelines 339 357 +18

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ingestPipelines 392.7KB 404.6KB +11.9KB

History

cc @ElenaStoeva

Copy link
Contributor

@SoniaSanzV SoniaSanzV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ElenaStoeva ElenaStoeva merged commit 996eb73 into elastic:main Oct 22, 2024
23 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11457067376

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 22, 2024
## Summary

This PR adds some copy changes to the Manage processors pages.

1. Empty prompt
- Width and padding of the prompt is adjusted so that "IP" in the title
starts in the 2nd line
- Description is updated
<img width="800" alt="Screenshot 2024-10-18 at 17 00 53"
src="https://github.com/user-attachments/assets/51aa6cdc-5eb4-4c54-8960-7ee273d82ef5">

2. Add database modal
- Copy in callouts is updated
- The help text of the "Type" field is updated
- The text in the "Database already exists" error callout is updated
<img width="1490" alt="Screenshot 2024-10-21 at 09 34 12"
src="https://github.com/user-attachments/assets/ab3c2e21-4457-435f-a4c3-874c6edcb2ce">
<img width="1498" alt="Screenshot 2024-10-18 at 17 24 43"
src="https://github.com/user-attachments/assets/a0c15f5d-9360-4ee7-806d-2b5b64b6fd2a">

3. Manage processors page
- The title of the page is changed from "GeoIP" to "IP Location"
<img width="800" alt="Screenshot 2024-10-18 at 17 20 01"
src="https://github.com/user-attachments/assets/cde8b070-9664-42df-b71a-723a5356d4a2">

(cherry picked from commit 996eb73)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

ElenaStoeva added a commit to ElenaStoeva/kibana that referenced this pull request Oct 22, 2024
## Summary

This PR adds some copy changes to the Manage processors pages.

1. Empty prompt
- Width and padding of the prompt is adjusted so that "IP" in the title
starts in the 2nd line
- Description is updated
<img width="800" alt="Screenshot 2024-10-18 at 17 00 53"
src="https://github.com/user-attachments/assets/51aa6cdc-5eb4-4c54-8960-7ee273d82ef5">

2. Add database modal
- Copy in callouts is updated
- The help text of the "Type" field is updated
- The text in the "Database already exists" error callout is updated
<img width="1490" alt="Screenshot 2024-10-21 at 09 34 12"
src="https://github.com/user-attachments/assets/ab3c2e21-4457-435f-a4c3-874c6edcb2ce">
<img width="1498" alt="Screenshot 2024-10-18 at 17 24 43"
src="https://github.com/user-attachments/assets/a0c15f5d-9360-4ee7-806d-2b5b64b6fd2a">

3. Manage processors page
- The title of the page is changed from "GeoIP" to "IP Location"
<img width="800" alt="Screenshot 2024-10-18 at 17 20 01"
src="https://github.com/user-attachments/assets/cde8b070-9664-42df-b71a-723a5356d4a2">

(cherry picked from commit 996eb73)
@ElenaStoeva
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.16

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 22, 2024
…197187)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Ingest Pipelines] Update copy in Manage processors
(#196923)](#196923)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Elena
Stoeva","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-22T09:14:42Z","message":"[Ingest
Pipelines] Update copy in Manage processors (#196923)\n\n##
Summary\r\n\r\nThis PR adds some copy changes to the Manage processors
pages.\r\n\r\n1. Empty prompt\r\n- Width and padding of the prompt is
adjusted so that \"IP\" in the title\r\nstarts in the 2nd line\r\n-
Description is updated\r\n<img width=\"800\" alt=\"Screenshot 2024-10-18
at 17 00
53\"\r\nsrc=\"https://github.com/user-attachments/assets/51aa6cdc-5eb4-4c54-8960-7ee273d82ef5\">\r\n\r\n\r\n2.
Add database modal\r\n- Copy in callouts is updated\r\n- The help text
of the \"Type\" field is updated\r\n- The text in the \"Database already
exists\" error callout is updated\r\n<img width=\"1490\"
alt=\"Screenshot 2024-10-21 at 09 34
12\"\r\nsrc=\"https://github.com/user-attachments/assets/ab3c2e21-4457-435f-a4c3-874c6edcb2ce\">\r\n<img
width=\"1498\" alt=\"Screenshot 2024-10-18 at 17 24
43\"\r\nsrc=\"https://github.com/user-attachments/assets/a0c15f5d-9360-4ee7-806d-2b5b64b6fd2a\">\r\n\r\n\r\n3.
Manage processors page\r\n- The title of the page is changed from
\"GeoIP\" to \"IP Location\"\r\n<img width=\"800\" alt=\"Screenshot
2024-10-18 at 17 20
01\"\r\nsrc=\"https://github.com/user-attachments/assets/cde8b070-9664-42df-b71a-723a5356d4a2\">","sha":"996eb73811c665945f8c4425d1e8e89fa9688b40","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Kibana
Management","release_note:skip","v9.0.0","Feature:Ingest Node
Pipelines","backport:prev-minor"],"title":"[Ingest Pipelines] Update
copy in Manage
processors","number":196923,"url":"https://github.com/elastic/kibana/pull/196923","mergeCommit":{"message":"[Ingest
Pipelines] Update copy in Manage processors (#196923)\n\n##
Summary\r\n\r\nThis PR adds some copy changes to the Manage processors
pages.\r\n\r\n1. Empty prompt\r\n- Width and padding of the prompt is
adjusted so that \"IP\" in the title\r\nstarts in the 2nd line\r\n-
Description is updated\r\n<img width=\"800\" alt=\"Screenshot 2024-10-18
at 17 00
53\"\r\nsrc=\"https://github.com/user-attachments/assets/51aa6cdc-5eb4-4c54-8960-7ee273d82ef5\">\r\n\r\n\r\n2.
Add database modal\r\n- Copy in callouts is updated\r\n- The help text
of the \"Type\" field is updated\r\n- The text in the \"Database already
exists\" error callout is updated\r\n<img width=\"1490\"
alt=\"Screenshot 2024-10-21 at 09 34
12\"\r\nsrc=\"https://github.com/user-attachments/assets/ab3c2e21-4457-435f-a4c3-874c6edcb2ce\">\r\n<img
width=\"1498\" alt=\"Screenshot 2024-10-18 at 17 24
43\"\r\nsrc=\"https://github.com/user-attachments/assets/a0c15f5d-9360-4ee7-806d-2b5b64b6fd2a\">\r\n\r\n\r\n3.
Manage processors page\r\n- The title of the page is changed from
\"GeoIP\" to \"IP Location\"\r\n<img width=\"800\" alt=\"Screenshot
2024-10-18 at 17 20
01\"\r\nsrc=\"https://github.com/user-attachments/assets/cde8b070-9664-42df-b71a-723a5356d4a2\">","sha":"996eb73811c665945f8c4425d1e8e89fa9688b40"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196923","number":196923,"mergeCommit":{"message":"[Ingest
Pipelines] Update copy in Manage processors (#196923)\n\n##
Summary\r\n\r\nThis PR adds some copy changes to the Manage processors
pages.\r\n\r\n1. Empty prompt\r\n- Width and padding of the prompt is
adjusted so that \"IP\" in the title\r\nstarts in the 2nd line\r\n-
Description is updated\r\n<img width=\"800\" alt=\"Screenshot 2024-10-18
at 17 00
53\"\r\nsrc=\"https://github.com/user-attachments/assets/51aa6cdc-5eb4-4c54-8960-7ee273d82ef5\">\r\n\r\n\r\n2.
Add database modal\r\n- Copy in callouts is updated\r\n- The help text
of the \"Type\" field is updated\r\n- The text in the \"Database already
exists\" error callout is updated\r\n<img width=\"1490\"
alt=\"Screenshot 2024-10-21 at 09 34
12\"\r\nsrc=\"https://github.com/user-attachments/assets/ab3c2e21-4457-435f-a4c3-874c6edcb2ce\">\r\n<img
width=\"1498\" alt=\"Screenshot 2024-10-18 at 17 24
43\"\r\nsrc=\"https://github.com/user-attachments/assets/a0c15f5d-9360-4ee7-806d-2b5b64b6fd2a\">\r\n\r\n\r\n3.
Manage processors page\r\n- The title of the page is changed from
\"GeoIP\" to \"IP Location\"\r\n<img width=\"800\" alt=\"Screenshot
2024-10-18 at 17 20
01\"\r\nsrc=\"https://github.com/user-attachments/assets/cde8b070-9664-42df-b71a-723a5356d4a2\">","sha":"996eb73811c665945f8c4425d1e8e89fa9688b40"}}]}]
BACKPORT-->

Co-authored-by: Elena Stoeva <[email protected]>
ElenaStoeva added a commit that referenced this pull request Oct 22, 2024
…197196)

# Backport

This will backport the following commits from `main` to `8.16`:
- [[Ingest Pipelines] Update copy in Manage processors
(#196923)](#196923)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Elena
Stoeva","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-22T09:14:42Z","message":"[Ingest
Pipelines] Update copy in Manage processors (#196923)\n\n##
Summary\r\n\r\nThis PR adds some copy changes to the Manage processors
pages.\r\n\r\n1. Empty prompt\r\n- Width and padding of the prompt is
adjusted so that \"IP\" in the title\r\nstarts in the 2nd line\r\n-
Description is updated\r\n<img width=\"800\" alt=\"Screenshot 2024-10-18
at 17 00
53\"\r\nsrc=\"https://github.com/user-attachments/assets/51aa6cdc-5eb4-4c54-8960-7ee273d82ef5\">\r\n\r\n\r\n2.
Add database modal\r\n- Copy in callouts is updated\r\n- The help text
of the \"Type\" field is updated\r\n- The text in the \"Database already
exists\" error callout is updated\r\n<img width=\"1490\"
alt=\"Screenshot 2024-10-21 at 09 34
12\"\r\nsrc=\"https://github.com/user-attachments/assets/ab3c2e21-4457-435f-a4c3-874c6edcb2ce\">\r\n<img
width=\"1498\" alt=\"Screenshot 2024-10-18 at 17 24
43\"\r\nsrc=\"https://github.com/user-attachments/assets/a0c15f5d-9360-4ee7-806d-2b5b64b6fd2a\">\r\n\r\n\r\n3.
Manage processors page\r\n- The title of the page is changed from
\"GeoIP\" to \"IP Location\"\r\n<img width=\"800\" alt=\"Screenshot
2024-10-18 at 17 20
01\"\r\nsrc=\"https://github.com/user-attachments/assets/cde8b070-9664-42df-b71a-723a5356d4a2\">","sha":"996eb73811c665945f8c4425d1e8e89fa9688b40","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Kibana
Management","release_note:skip","v9.0.0","Feature:Ingest Node
Pipelines","backport:prev-minor","v8.16.0","v8.17.0"],"number":196923,"url":"https://github.com/elastic/kibana/pull/196923","mergeCommit":{"message":"[Ingest
Pipelines] Update copy in Manage processors (#196923)\n\n##
Summary\r\n\r\nThis PR adds some copy changes to the Manage processors
pages.\r\n\r\n1. Empty prompt\r\n- Width and padding of the prompt is
adjusted so that \"IP\" in the title\r\nstarts in the 2nd line\r\n-
Description is updated\r\n<img width=\"800\" alt=\"Screenshot 2024-10-18
at 17 00
53\"\r\nsrc=\"https://github.com/user-attachments/assets/51aa6cdc-5eb4-4c54-8960-7ee273d82ef5\">\r\n\r\n\r\n2.
Add database modal\r\n- Copy in callouts is updated\r\n- The help text
of the \"Type\" field is updated\r\n- The text in the \"Database already
exists\" error callout is updated\r\n<img width=\"1490\"
alt=\"Screenshot 2024-10-21 at 09 34
12\"\r\nsrc=\"https://github.com/user-attachments/assets/ab3c2e21-4457-435f-a4c3-874c6edcb2ce\">\r\n<img
width=\"1498\" alt=\"Screenshot 2024-10-18 at 17 24
43\"\r\nsrc=\"https://github.com/user-attachments/assets/a0c15f5d-9360-4ee7-806d-2b5b64b6fd2a\">\r\n\r\n\r\n3.
Manage processors page\r\n- The title of the page is changed from
\"GeoIP\" to \"IP Location\"\r\n<img width=\"800\" alt=\"Screenshot
2024-10-18 at 17 20
01\"\r\nsrc=\"https://github.com/user-attachments/assets/cde8b070-9664-42df-b71a-723a5356d4a2\">","sha":"996eb73811c665945f8c4425d1e8e89fa9688b40"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196923","number":196923,"mergeCommit":{"message":"[Ingest
Pipelines] Update copy in Manage processors (#196923)\n\n##
Summary\r\n\r\nThis PR adds some copy changes to the Manage processors
pages.\r\n\r\n1. Empty prompt\r\n- Width and padding of the prompt is
adjusted so that \"IP\" in the title\r\nstarts in the 2nd line\r\n-
Description is updated\r\n<img width=\"800\" alt=\"Screenshot 2024-10-18
at 17 00
53\"\r\nsrc=\"https://github.com/user-attachments/assets/51aa6cdc-5eb4-4c54-8960-7ee273d82ef5\">\r\n\r\n\r\n2.
Add database modal\r\n- Copy in callouts is updated\r\n- The help text
of the \"Type\" field is updated\r\n- The text in the \"Database already
exists\" error callout is updated\r\n<img width=\"1490\"
alt=\"Screenshot 2024-10-21 at 09 34
12\"\r\nsrc=\"https://github.com/user-attachments/assets/ab3c2e21-4457-435f-a4c3-874c6edcb2ce\">\r\n<img
width=\"1498\" alt=\"Screenshot 2024-10-18 at 17 24
43\"\r\nsrc=\"https://github.com/user-attachments/assets/a0c15f5d-9360-4ee7-806d-2b5b64b6fd2a\">\r\n\r\n\r\n3.
Manage processors page\r\n- The title of the page is changed from
\"GeoIP\" to \"IP Location\"\r\n<img width=\"800\" alt=\"Screenshot
2024-10-18 at 17 20
01\"\r\nsrc=\"https://github.com/user-attachments/assets/cde8b070-9664-42df-b71a-723a5356d4a2\">","sha":"996eb73811c665945f8c4425d1e8e89fa9688b40"}},{"branch":"8.16","label":"v8.16.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","labelRegex":"^v8.17.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/197187","number":197187,"state":"OPEN"}]}]
BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:Ingest Node Pipelines Ingest node pipelines management release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.16.0 v8.17.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants