fix: dynamically update timestamps based on the chosen timezone in the Advanced Settings #196977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulinashakirova
added
release_note:fix
v9.0.0
Team:SharedUX
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
Dosant
reviewed
Oct 21, 2024
...content-management/content_insights/content_insights_public/src/components/activity_view.tsx
Outdated
Show resolved
Hide resolved
|
Let's backport to prev-major (so it gets into 8.16) |
paulinashakirova
added
backport:prev-major
paulinashakirova
force-pushed
the
dynamic-update-timestamp-based-on-timezone-in-advanced-settings
branch
from
d69b37f
to
65d0179
Compare
…n-advanced-settings
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
|
🤦 sorry, I confused with another feature. this could be backported to 8.15 |
paulinashakirova
added
backport:version
paulinashakirova
added
v8.16.0
backport:prev-major
|
Starting backport for target branches: 8.15, 8.16, 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 24, 2024
…e Advanced Settings (elastic#196977) ## Summary This PR fixes the [elastic#190562](elastic#190562) where the created and updated timestamps for Dashboards do not respect the default timezone settings in advanced settings. Currently, if the user changes the timezone in the advanced settings, the timestamps for the activity monitor flyout still display timestamps from the default browser timezone. This PR ensures that the timestamps display in the desired timezone.   (cherry picked from commit 7fa1e18)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 24, 2024
…e Advanced Settings (elastic#196977) ## Summary This PR fixes the [elastic#190562](elastic#190562) where the created and updated timestamps for Dashboards do not respect the default timezone settings in advanced settings. Currently, if the user changes the timezone in the advanced settings, the timestamps for the activity monitor flyout still display timestamps from the default browser timezone. This PR ensures that the timestamps display in the desired timezone.   (cherry picked from commit 7fa1e18)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 24, 2024
… in the Advanced Settings (#196977) (#197641) # Backport This will backport the following commits from `main` to `8.x`: - [fix: dynamically update timestamps based on the chosen timezone in the Advanced Settings (#196977)](#196977) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Paulina Shakirova","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-24T13:21:12Z","message":"fix: dynamically update timestamps based on the chosen timezone in the Advanced Settings (#196977)\n\n## Summary\r\n\r\nThis PR fixes the\r\n[#190562](#190562) where the\r\ncreated and updated timestamps for Dashboards do not respect the default\r\ntimezone settings in advanced settings.\r\n\r\nCurrently, if the user changes the timezone in the advanced settings,\r\nthe timestamps for the activity monitor flyout still display timestamps\r\nfrom the default browser timezone. This PR ensures that the timestamps\r\ndisplay in the desired timezone.\r\n\r\n\r\n\r\n","sha":"7fa1e18516c484609749aaec7f58a39c302cd34f","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","Team:SharedUX","backport:prev-major"],"title":"fix: dynamically update timestamps based on the chosen timezone in the Advanced Settings","number":196977,"url":"https://github.com/elastic/kibana/pull/196977","mergeCommit":{"message":"fix: dynamically update timestamps based on the chosen timezone in the Advanced Settings (#196977)\n\n## Summary\r\n\r\nThis PR fixes the\r\n[#190562](#190562) where the\r\ncreated and updated timestamps for Dashboards do not respect the default\r\ntimezone settings in advanced settings.\r\n\r\nCurrently, if the user changes the timezone in the advanced settings,\r\nthe timestamps for the activity monitor flyout still display timestamps\r\nfrom the default browser timezone. This PR ensures that the timestamps\r\ndisplay in the desired timezone.\r\n\r\n\r\n\r\n","sha":"7fa1e18516c484609749aaec7f58a39c302cd34f"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196977","number":196977,"mergeCommit":{"message":"fix: dynamically update timestamps based on the chosen timezone in the Advanced Settings (#196977)\n\n## Summary\r\n\r\nThis PR fixes the\r\n[#190562](#190562) where the\r\ncreated and updated timestamps for Dashboards do not respect the default\r\ntimezone settings in advanced settings.\r\n\r\nCurrently, if the user changes the timezone in the advanced settings,\r\nthe timestamps for the activity monitor flyout still display timestamps\r\nfrom the default browser timezone. This PR ensures that the timestamps\r\ndisplay in the desired timezone.\r\n\r\n\r\n\r\n","sha":"7fa1e18516c484609749aaec7f58a39c302cd34f"}}]}] BACKPORT--> Co-authored-by: Paulina Shakirova <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Oct 24, 2024
…e in the Advanced Settings (#196977) (#197640) # Backport This will backport the following commits from `main` to `8.16`: - [fix: dynamically update timestamps based on the chosen timezone in the Advanced Settings (#196977)](#196977) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Paulina Shakirova","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-24T13:21:12Z","message":"fix: dynamically update timestamps based on the chosen timezone in the Advanced Settings (#196977)\n\n## Summary\r\n\r\nThis PR fixes the\r\n[#190562](#190562) where the\r\ncreated and updated timestamps for Dashboards do not respect the default\r\ntimezone settings in advanced settings.\r\n\r\nCurrently, if the user changes the timezone in the advanced settings,\r\nthe timestamps for the activity monitor flyout still display timestamps\r\nfrom the default browser timezone. This PR ensures that the timestamps\r\ndisplay in the desired timezone.\r\n\r\n\r\n\r\n","sha":"7fa1e18516c484609749aaec7f58a39c302cd34f","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","Team:SharedUX","backport:prev-major"],"title":"fix: dynamically update timestamps based on the chosen timezone in the Advanced Settings","number":196977,"url":"https://github.com/elastic/kibana/pull/196977","mergeCommit":{"message":"fix: dynamically update timestamps based on the chosen timezone in the Advanced Settings (#196977)\n\n## Summary\r\n\r\nThis PR fixes the\r\n[#190562](#190562) where the\r\ncreated and updated timestamps for Dashboards do not respect the default\r\ntimezone settings in advanced settings.\r\n\r\nCurrently, if the user changes the timezone in the advanced settings,\r\nthe timestamps for the activity monitor flyout still display timestamps\r\nfrom the default browser timezone. This PR ensures that the timestamps\r\ndisplay in the desired timezone.\r\n\r\n\r\n\r\n","sha":"7fa1e18516c484609749aaec7f58a39c302cd34f"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196977","number":196977,"mergeCommit":{"message":"fix: dynamically update timestamps based on the chosen timezone in the Advanced Settings (#196977)\n\n## Summary\r\n\r\nThis PR fixes the\r\n[#190562](#190562) where the\r\ncreated and updated timestamps for Dashboards do not respect the default\r\ntimezone settings in advanced settings.\r\n\r\nCurrently, if the user changes the timezone in the advanced settings,\r\nthe timestamps for the activity monitor flyout still display timestamps\r\nfrom the default browser timezone. This PR ensures that the timestamps\r\ndisplay in the desired timezone.\r\n\r\n\r\n\r\n","sha":"7fa1e18516c484609749aaec7f58a39c302cd34f"}}]}] BACKPORT--> Co-authored-by: Paulina Shakirova <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the #190562 where the created and updated timestamps for Dashboards do not respect the default timezone settings in advanced settings.
Currently, if the user changes the timezone in the advanced settings, the timestamps for the activity monitor flyout still display timestamps from the default browser timezone. This PR ensures that the timestamps display in the desired timezone.