Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] fix: dynamically update timestamps based on the chosen timezone in the Advanced Settings (#196977) #197641

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

…e Advanced Settings (elastic#196977)

## Summary

This PR fixes the
[elastic#190562](elastic#190562) where the
created and updated timestamps for Dashboards do not respect the default
timezone settings in advanced settings.

Currently, if the user changes the timezone in the advanced settings,
the timestamps for the activity monitor flyout still display timestamps
from the default browser timezone. This PR ensures that the timestamps
display in the desired timezone.

![Screenshot 2024-10-19 at 13 35
00](https://github.com/user-attachments/assets/399a3b0a-d16a-4010-8560-06f3a4bcbc96)

![Screenshot 2024-10-19 at 13 36
02](https://github.com/user-attachments/assets/62a5bf2f-c5c3-474d-b810-3b1f414d2b14)

(cherry picked from commit 7fa1e18)
@kibanamachine kibanamachine merged commit b0179ef into elastic:8.x Oct 24, 2024
23 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dashboard 643.0KB 643.1KB +66.0B
eventAnnotationListing 227.6KB 227.7KB +71.0B
filesManagement 121.3KB 121.4KB +70.0B
graph 414.0KB 414.1KB +71.0B
maps 3.0MB 3.0MB +79.0B
visualizations 316.2KB 316.3KB +74.0B
total +431.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
dashboard 50.4KB 50.4KB +58.0B
eventAnnotationListing 10.9KB 11.0KB +58.0B
filesManagement 4.0KB 4.0KB +58.0B
graph 8.0KB 8.1KB +58.0B
maps 54.3KB 54.4KB +58.0B
visualizations 70.9KB 71.0KB +58.0B
total +348.0B

cc @paulinashakirova

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants