Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cases to troubleshooting and support matrix pages #3105

Merged
merged 8 commits into from
Aug 11, 2023

Conversation

paulb-elastic
Copy link
Contributor

@paulb-elastic paulb-elastic commented Jul 25, 2023

Added about a direct ES connection being needed on the Support Matrix and troubleshooting pages as it has come up with users of the Service, not just with Private Locations, so need to make this message clearer.

Also added a note about scaling as mentioned in #3081 (comment)

@paulb-elastic paulb-elastic added backport-8.9 Automated backport with mergify backport-8.8 Automated backport with mergify labels Jul 25, 2023
@github-actions
Copy link
Contributor

A documentation preview will be available soon:

Copy link
Contributor

@andrewvc andrewvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@paulb-elastic
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/docs

@paulb-elastic paulb-elastic changed the title [WIP] Add cases to troubleshooting and support matrix pages Add cases to troubleshooting and support matrix pages Aug 1, 2023
@paulb-elastic
Copy link
Contributor Author

No longer WIP, ready for review (note the build failed with a infrastructure problem so the HTML preview is currently outdated)

@paulb-elastic paulb-elastic marked this pull request as ready for review August 1, 2023 10:22
@paulb-elastic paulb-elastic requested a review from a team as a code owner August 1, 2023 10:22
Copy link
Contributor

@emilioalvap emilioalvap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paulb-elastic
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/docs

Comment on lines 76 to 78
[discrete]
[[synthetics-troubleshooting-no-agent-running]]
== Browser monitor configured to run on a {private-location} not running to schedule
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build is failing because this id is used above (probably a copy-paste error?). Maybe something like this:

Suggested change
[discrete]
[[synthetics-troubleshooting-no-agent-running]]
== Browser monitor configured to run on a {private-location} not running to schedule
[discrete]
[[synthetics-troubleshooting-private-location-off-schedule]]
== Browser monitor configured to run on a {private-location} not running to schedule

@paulb-elastic
Copy link
Contributor Author

@colleenmcginnis thank you - I totally missed that dupe

@paulb-elastic
Copy link
Contributor Author

@colleenmcginnis would you mind giving it a final review please?

Copy link
Contributor

@colleenmcginnis colleenmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions below!

docs/en/observability/synthetics-support-matrix.asciidoc Outdated Show resolved Hide resolved
docs/en/observability/synthetics-troubleshooting.asciidoc Outdated Show resolved Hide resolved
docs/en/observability/synthetics-troubleshooting.asciidoc Outdated Show resolved Hide resolved
docs/en/observability/synthetics-troubleshooting.asciidoc Outdated Show resolved Hide resolved
docs/en/observability/synthetics-troubleshooting.asciidoc Outdated Show resolved Hide resolved
Copy link
Contributor

@colleenmcginnis colleenmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paulb-elastic paulb-elastic merged commit 3b7ef4b into elastic:main Aug 11, 2023
1 check passed
@paulb-elastic paulb-elastic deleted the direct-es-on-support-matrix branch August 11, 2023 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.8 Automated backport with mergify backport-8.9 Automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants