Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs about the Hosts metrics tab #3939

Merged
merged 3 commits into from
May 30, 2024
Merged

Conversation

dedemorton
Copy link
Contributor

@dedemorton dedemorton commented May 29, 2024

Closes #3788.

Also adds a couple other additional (minor) changes:

  • Cleans up some outdated text from other subtle UI changes.
  • Moves the screenshots about host details tabs to appear after the text that explains the tab. Why? Users looking at the UI probably don't need the screenshot and would prefer to see text. Other users (who are maybe trying to figure out what is possible) will still see the screenshot but it won't interfere with the users ability to scan and find info.
  • Cropped out the search bar in some of the screen captures. Why? Having inconsistent timestamps at the top of each screenshot looked weird plus didn't add a lot since the search field is not unique to each screen. Note that I didn't retake all the screenshots...just cropped them.

TODO (after merging):

@dedemorton dedemorton self-assigned this May 29, 2024
Copy link
Contributor

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

Copy link
Contributor

mergify bot commented May 29, 2024

This pull request does not have a backport label. Could you fix it @dedemorton? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-/d./d is the label to automatically backport to the /d./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label May 29, 2024
@dedemorton dedemorton marked this pull request as ready for review May 29, 2024 20:02
@dedemorton dedemorton requested a review from a team as a code owner May 29, 2024 20:02
@dedemorton
Copy link
Contributor Author

This PR is ready for review now!

neptunian
neptunian previously approved these changes May 30, 2024
@dedemorton dedemorton added backport-8.14 Automated backport with mergify and removed backport-skip Skip notification from the automated backport with mergify labels May 30, 2024
@dedemorton dedemorton enabled auto-merge (squash) May 30, 2024 17:21
@dedemorton dedemorton disabled auto-merge May 30, 2024 17:30
@dedemorton dedemorton merged commit 8608374 into elastic:main May 30, 2024
4 checks passed
@dedemorton dedemorton deleted the issue#3788 branch May 30, 2024 19:37
mergify bot pushed a commit that referenced this pull request May 30, 2024
* Add docs about the Hosts metrics tab

* Comment out section about inspect option

* Remove outdated TODO

(cherry picked from commit 8608374)
dedemorton added a commit that referenced this pull request May 30, 2024
* Add docs about the Hosts metrics tab

* Comment out section about inspect option

* Remove outdated TODO

(cherry picked from commit 8608374)

Co-authored-by: DeDe Morton <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.14 Automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request]: Host Metrics Tab
3 participants