Implementation of embedded client #2297
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magnetised
force-pushed
the
2256-add-embedded-client-implementation
branch
2 times, most recently
from
172076c to
def5564
Compare
magnetised
force-pushed
the
2256-add-embedded-client-implementation
branch
2 times, most recently
from
86fa1a4 to
d3fd28a
Compare
magnetised
force-pushed
the
2256-allow-for-a-pure-elixir-api
branch
from
ea6edeb to
c0e4d05
Compare
magnetised
force-pushed
the
2256-add-embedded-client-implementation
branch
4 times, most recently
from
d302051 to
71f6e0e
Compare
magnetised
force-pushed
the
2256-add-embedded-client-implementation
branch
from
71f6e0e to
78ce6d0
Compare
which talks to electric over the internal api, not http
magnetised
force-pushed
the
2256-add-embedded-client-implementation
branch
from
78ce6d0 to
db7c4a3
Compare
msfstef
approved these changes
Feb 6, 2025
| quote( | ||
| do: %ControlMessage{ | ||
| control: :up_to_date, | ||
| offset: offset(unquote(tx), unquote(op)) |
There was a problem hiding this comment.
do we still include offsets in the control messages?
There was a problem hiding this comment.
Never did on the wire, actually
| @@ -47,6 +47,10 @@ defmodule Electric.Plug.Utils do | |||
| end) | |||
| end | |||
|
|
|||
| def parse_columns_param([col | _] = columns) when is_binary(col) do | |||
There was a problem hiding this comment.
nit: techincally just ensuring the first col is binary (and not if they are valid postgres identifiers) - you could potentially have the string splitting in L34 as a separate step and then recursively call into itself to do the rest of the parsing?
| def type, do: {:array, :string} | ||
|
|
||
| def cast([_ | _] = columns) do | ||
| {:ok, Enum.map(columns, &to_string/1)} |
There was a problem hiding this comment.
nit: potentially worth passing through the parser again to check that they are valid pg identifiers etc? see above comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
which talks to electric over the internal api, not http