add abstraction to manage shape request-response behaviour #2273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for electric-next ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
magnetised
force-pushed
the
2256-allow-for-a-pure-elixir-api
branch
4 times, most recently
from
9917d15 to
13bb6c4
Compare
icehaunter
reviewed
Feb 5, 2025
and configure the application with it
it's probabaly just that the shape wasn't created
make sure the sync has at least initialised before dropping the table
magnetised
force-pushed
the
2256-allow-for-a-pure-elixir-api
branch
from
ea6edeb to
c0e4d05
Compare
icehaunter
requested changes
Feb 5, 2025
There was a problem hiding this comment.
This a great change. I think this encapsulation is worth it and makes parts of the flow much cleaner. I think some nested structure updates are a bit hard to follow at times, but that's OK. I have some nitpicks, with only blocking request being the one about exposing stacktraces
Co-authored-by: Ilia Borovitinov <[email protected]>
icehaunter
reviewed
Feb 5, 2025
add some convenience functions to clean up the api just return a response from do_serve_shape_log normalise error messages
icehaunter
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used by #2297