Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add supports notarize file #154

Closed
wants to merge 1 commit into from
Closed

feat: Add supports notarize file #154

wants to merge 1 commit into from

Conversation

panther7
Copy link
Contributor

@panther7 panther7 requested a review from a team as a code owner August 11, 2023 09:00
@panther7 panther7 force-pushed the notary-file branch 2 times, most recently from 65f2e91 to a0bfbf6 Compare August 11, 2023 09:33
@panther7 panther7 mentioned this pull request Aug 11, 2023
Closed
@panther7 panther7 changed the title Add supports notarize file feat: Add supports notarize file Aug 14, 2023
@panther7 panther7 force-pushed the notary-file branch 2 times, most recently from 5143b0e to 4a0f697 Compare August 15, 2023 09:11
MarshallOfSound
MarshallOfSound requested changes Sep 1, 2023
View reviewed changes
Copy link
Member

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe that you can staple the app inside a zip file, or at least that was the limitation when notarization was first released. Is that limitation no longer a problem?

@panther7
Copy link
Contributor Author

I don't know if app in zip is supported.
In our project we using dmg file, which is supported.

I can modify this PR for dmg/pkg only.

@MarshallOfSound

@panther7
Copy link
Contributor Author

From docs:

notarytool submit works only with UDIF disk images, signed "flat" installer packages, and zip files. notarytool will do a shallow validation of the file before submission. Passing any other file format in file-path to notarytool submit will result in an error.

I think, that is not problem, if someone try submit "unsupported" file, apple backend return error.

@erickzhao erickzhao mentioned this pull request Nov 15, 2023
Merged
@DanielMcAssey DanielMcAssey mentioned this pull request Nov 15, 2023
Merged
@MarshallOfSound
Copy link
Member

Superseded by #169

@panther7 panther7 mentioned this pull request Feb 25, 2024
Open
@panther7 panther7 deleted the notary-file branch February 28, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound Awaiting requested review from MarshallOfSound

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@panther7 @MarshallOfSound