Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for .pkg and .dmg files #169

Merged
merged 2 commits into from
Feb 15, 2024

Conversation

DanielMcAssey
Copy link
Contributor

@DanielMcAssey DanielMcAssey commented Nov 15, 2023

Alternative to #154 that specifically targets dmg and pkg files.

Created this from comment on #152.

This is currently broken with change #152, as codesign doesn't seem to like reading .pkg

@DanielMcAssey DanielMcAssey requested a review from a team as a code owner November 15, 2023 23:20
@MarshallOfSound MarshallOfSound merged commit 571ebac into electron:main Feb 15, 2024
3 checks passed
Copy link

🎉 This PR is included in version 2.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants