Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favorites label does not move when spaces panel is expanded #17283

Open
aaronraimist opened this issue May 13, 2021 · 7 comments
Open

Favorites label does not move when spaces panel is expanded #17283

aaronraimist opened this issue May 13, 2021 · 7 comments
Labels
A-Room-List A-Spaces Spaces, groups, communities O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-Platform-Specific

Comments

@aaronraimist
Copy link
Collaborator

aaronraimist commented May 13, 2021

In Safari when I expand the spaces panel, the Favorites label in the room list stays in place and goes on top of the spaces panel.

It fixes itself if I hover my mouse over Favorites but then when I collapse the spaces panel, the Favorites label gets stuck in place again.

It only seems to affect the Favorites label, not People or Rooms.

Version information

  • Platform: web
  • Browser: Safari 14.1

Can't reproduce in Firefox

@aaronraimist aaronraimist added T-Defect Z-Platform-Specific S-Minor Impairs non-critical functionality or suitable workarounds exist A-Room-List A-Spaces Spaces, groups, communities labels May 13, 2021
@t3chguy
Copy link
Member

t3chguy commented May 13, 2021

It'll only be affecting the sticky top/bottom sublists, which use absolute-positioning.
I haven't seen this in Chrome/FF so is likely a case of Safari missing the HTML spec boat.

@t3chguy t3chguy self-assigned this Sep 28, 2021
@t3chguy
Copy link
Member

t3chguy commented Sep 29, 2021

This actually looks to be a Safari/Webkit bug, because we don't actually specify a left offset on the position, which explains why merely hovering on the element is enough for Safari to fix itself.

This would be fixed by matrix-org/matrix-react-sdk#6054

@ogarcia
Copy link

ogarcia commented Mar 25, 2023

It doesn't just happen with favorites, it happens with the first tag of any list (whatever it is).

It is a problem that happens in any browser with WebKit engine. It happens on Mac with Safari and also on Linux with Epiphany (Gnome WEB). It also happens in applications that are based on this engine as Revolt.

@t3chguy
Copy link
Member

t3chguy commented Aug 7, 2023

I cannot reproduce this on latest Safari so looks to have been fixed upstream

@t3chguy t3chguy closed this as completed Aug 7, 2023
@ogarcia
Copy link

ogarcia commented Aug 8, 2023

This issue is not fixed. It still occurs on Linux with Epiphany (Gnome WEB).

@t3chguy
Copy link
Member

t3chguy commented Aug 8, 2023

@ogarcia it is fixed in the supported browsers - see https://github.com/vector-im/element-web#supported-environments

@kenrachynski
Copy link

kenrachynski commented Sep 4, 2023

I have been able to duplicate this on Safari 16.6 on macOS 13.5.1 (Ventura).
image

Typically it's my People list when collapsed that slides under the spaces list.
A bit of debugging showed that I could get the collapsed header to put itself into place when the height of the browser forced the header to be sticky.

If I also collapse my room list, I can get the browser pretty short before the People label snaps into place properly.

I'm willing to debug this.

Screen.Recording.2023-09-04.at.11.09.33-SD.480p.mov

@t3chguy t3chguy reopened this Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Room-List A-Spaces Spaces, groups, communities O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-Platform-Specific
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants