-
-
Notifications
You must be signed in to change notification settings - Fork 833
Conversation
Also fixes #14493 |
position: sticky; | ||
top: 0; | ||
z-index: 9; | ||
background: rgb(245,245,245); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this ought to be a theme var
position: sticky; | ||
top: 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment has been minimized.
This comment has been minimized.
@SimonBrandner that looks like #6054 (comment) |
This comment has been minimized.
This comment has been minimized.
@gsouquet since we spoke last via DM on this, did you end up finding a solution for the bottom/next section headers? |
@nadonomy A full CSS solution will not be possible as the property make elements stick at the top of the visible area of the elements. However we can explore more performant ways of approaching this using an |
@gsouquet apologies for not following up explicitly on this. When developing this version of the room list we found the bottom sticky headers were essential. Keen to not rip them out when refactoring. Thoughts:
If the effort for 1 is low, it could be worth finish lining this PR with @janogarcia. If you'd prefer to see where arrive at with the info architecture work this quarter, we could liaise between yourself, @t3chguy & @niquewoodhouse. What are your thoughts? |
Fixes element-hq/element-web#14709
Fixes element-hq/element-web#14665
Fixes element-hq/element-web#14531
Fixes element-hq/element-web#14493
Fixes element-hq/element-web#17412
Fixes element-hq/element-web#17283
Asking for a design review by @matrix-org/design as implementing this requires us to remove the blurred background image as we need to have a background color set on the sublist header for this CSS implementation to work.
As an alternative to a solid background we could have a horizontal linear gradient.
Tested on
Overall the scrolling experience is way smoother. Looking at the recording it can seem that we are doing more work with the JavaScript implementation, but this is purely because now the browser is able to render at a higher frame rate
Before 🐌
After 🐎
This PR currently has no changelog labels, so will not be included in changelogs.
Add one of:
T-Deprecation
,T-Enhancement
,T-Defect
,T-Task
to indicate what type of change this is plusX-Breaking-Change
if it's a breaking change.