Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide scroll to bottom button in pinned message e2e test #28255

Merged
merged 4 commits into from
Oct 22, 2024
Merged

Hide scroll to bottom button in pinned message e2e test #28255

merged 4 commits into from
Oct 22, 2024

Conversation

florianduros
Copy link
Member

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

Closes #28149

@florianduros florianduros added the T-Task Tasks for the team like planning label Oct 21, 2024
@florianduros florianduros marked this pull request as ready for review October 21, 2024 14:07
@florianduros florianduros requested a review from a team as a code owner October 21, 2024 14:07
@florianduros florianduros force-pushed the florianduros/fix-pinned-message-test-flake branch from 8b3feef to f88dc20 Compare October 21, 2024 15:37
@florianduros florianduros changed the title Mask scroll to bottom button in pinned message e2e test Hide scroll to bottom button in pinned message e2e test Oct 21, 2024
@florianduros florianduros added this pull request to the merge queue Oct 22, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 22, 2024
@florianduros florianduros added this pull request to the merge queue Oct 22, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 22, 2024
@florianduros florianduros added this pull request to the merge queue Oct 22, 2024
Merged via the queue into develop with commit 539025c Oct 22, 2024
32 checks passed
@florianduros florianduros deleted the florianduros/fix-pinned-message-test-flake branch October 22, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t3chguy t3chguy t3chguy approved these changes

@dbkr dbkr Awaiting requested review from dbkr dbkr is a code owner automatically assigned from element-hq/element-web-reviewers

@MidhunSureshR MidhunSureshR Awaiting requested review from MidhunSureshR MidhunSureshR is a code owner automatically assigned from element-hq/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
2 participants
@florianduros @t3chguy