Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide scroll to bottom button in pinned message e2e test #28255

Merged
merged 4 commits into from
Oct 22, 2024
Merged

Hide scroll to bottom button in pinned message e2e test #28255

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f88dc20
Hide scroll to bottom button in pinned message e2e test
florianduros Oct 21, 2024
4f1eb34
Remove redundant mask
florianduros Oct 21, 2024
bf70368
Update playwright/e2e/pinned-messages/pinned-messages.spec.ts
florianduros Oct 22, 2024
eb47b64
Merge branch 'develop' into florianduros/fix-pinned-message-test-flake
florianduros Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion playwright/e2e/pinned-messages/pinned-messages.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,16 @@ test.describe("Pinned messages", () => {

const tile = util.getEventTile("Msg1");
await expect(tile).toMatchScreenshot("pinned-message-Msg1.png", {
mask: [tile.locator(".mx_MessageTimestamp")],
mask: [
tile.locator(".mx_MessageTimestamp"),
page.getByRole("button", { name: "Scroll to most recent messages" }),
florianduros marked this conversation as resolved.
Show resolved Hide resolved
],
css: `
// Hide the jump to bottom button in the timeline to avoid flackiness
florianduros marked this conversation as resolved.
Show resolved Hide resolved
.mx_JumpToBottomButton {
display: none !important;
}
`,
});
});

Expand Down
Binary file modified ...snapshots/pinned-messages/pinned-messages.spec.ts/pinned-message-Msg1-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading