Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions: Refresh revert icon #1281

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

newhoa
Copy link
Collaborator

@newhoa newhoa commented May 17, 2024

Use new document shape, rounded arrow, newer style gradients. Make red to indicate risky action and differentiate it from the undo icon.

I'll throw some other options at the bottom, let me know which one is liked best and if this style is okay to go with and I will finish the other sizes. Thanks!

Current:
document-revert-current

Proposed:
document-revert

prop1

Other options:

Keep yellow arrow, use new document shape:
document-revert-yellow

Keep document shape, use red arrow:
document-revert-doc

Tried keeping the document shape on that last one, wasn't sure if overusing the square document would be too confusing with import, export, save, and revert.

Use new document shape, rounded arrow, newer style gradients.
Make red to indicate risky action and differentiate it from the undo icon.
@newhoa
Copy link
Collaborator Author

newhoa commented Sep 4, 2024

Updated this one, went with a deeper red (and added 16px, -rtl icons).

prop2

The 16px one looked weird without raising the arrow a bit. Raising the arrow made it look clearer.

16px-prop1

If the 24px one needs to be changed to match (or vice versa) let me know). It would look like this:

prop3

Anyway, I think this should be ready for review/feedback. Thanks!

@newhoa newhoa marked this pull request as ready for review September 4, 2024 07:32
@danirabbit
Copy link
Member

danirabbit commented Sep 4, 2024

Hey, so the difference between the tile shape and the portrait rectangle shape is that the tile shape represents the application, not the document. And it was yellow to match "undo" so that the metaphor would be that you're undoing all changes to the document instead of just undoing the last action. I've been tryng to consistently use a yellow arrow to represent traveling backwards in time

I think if we're updating the arrow shape here, we should also make sure to match the arrow tail shape to the new undo/redo arrows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants