Bump vscode-eslint extension to 3.0.10 to fix eslint/probeFailed
on newer configurations
#4489
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In repositories that use eslint over
9.0.0
you get errors withprobeFailed
from the eslint LSP server.Example log: lsp-log: eslint
It took me a while to understand why this was happening, and I found that the vscode-eslint version from my local VSCode didn't have this issue, so I tried using that
eslintServer
and the issue wasn't there anymore.Config used for local VSCode
eslintServer.js
This PR addresses this issue and makes
lsp-eslint
compatible with latest eslint version provided users reinstall their eslint serverHere's the PR from
lsp-server-binaries
to upload the latest vscode-eslint version: emacs-lsp/lsp-server-binaries#3Why is this happening? AFAIU, there are breaking changes between eslint 8.* and 9.* so if eslint config has rules that are only valid in 9.*, the probing fails. I think this is related: https://eslint.org/docs/latest/use/configure/migration-guide