Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ssl: Call correct function so that default groups are filtered for libcrypto support #8646

Closed
wants to merge 1 commit into from
Closed

ssl: Call correct function so that default groups are filtered for libcrypto support #8646

wants to merge 1 commit into from

Conversation

IngelaAndin
Copy link
Contributor

Closes #8489

@IngelaAndin IngelaAndin requested a review from u3s July 8, 2024 09:49
@IngelaAndin IngelaAndin self-assigned this Jul 8, 2024
@IngelaAndin IngelaAndin added the team:PS Assigned to OTP team PS label Jul 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 8, 2024 •
edited
Loading

CT Test Results

    2 files     67 suites   49m 30s ⏱️
  790 tests   746 ✅  44 💤 0 ❌
3 758 runs  2 964 ✅ 794 💤 0 ❌

Results for commit e7507ce.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@IngelaAndin IngelaAndin mentioned this pull request Jul 8, 2024
Closed
@IngelaAndin IngelaAndin added the testing currently being tested, tag is used by OTP internal CI label Jul 8, 2024
u3s
u3s reviewed Jul 8, 2024
View reviewed changes
lib/ssl/src/ssl.erl
handle_supported_groups_option(groups(default));
handle_supported_groups_option(tls_v1:default_groups());
Copy link
Contributor

@u3s u3s Jul 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand how this change can change anything.
Apart from 1 function call less ...

ssl.erl defines groups/1 as follows

groups(default) ->
tls_v1:default_groups().

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I think you are right, I think I misread it to do same as groups/0 due to reported symptoms. I will close this.

@IngelaAndin IngelaAndin closed this Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@u3s u3s u3s left review comments

Assignees

@IngelaAndin IngelaAndin

Labels
team:PS Assigned to OTP team PS testing currently being tested, tag is used by OTP internal CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IngelaAndin @u3s