Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ssl: Call correct function so that default groups are filtered for libcrypto support #8646

Closed
wants to merge 1 commit into from
Closed

ssl: Call correct function so that default groups are filtered for libcrypto support #8646

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/ssl/src/ssl.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2342,7 +2342,7 @@ opt_identity(UserOpts, #{versions := Versions} = Opts, _Env) ->
opt_supported_groups(UserOpts, #{versions := TlsVsns} = Opts, _Env) ->
SG = case get_opt_list(supported_groups, undefined, UserOpts, Opts) of
{default, undefined} ->
handle_supported_groups_option(groups(default));
handle_supported_groups_option(tls_v1:default_groups());
Copy link
Contributor

@u3s u3s Jul 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand how this change can change anything.
Apart from 1 function call less ...

ssl.erl defines groups/1 as follows

groups(default) ->
tls_v1:default_groups().

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I think you are right, I think I misread it to do same as groups/0 due to reported symptoms. I will close this.

{new, SG0} ->
assert_version_dep(supported_groups, TlsVsns, ['tlsv1.3']),
handle_supported_groups_option(SG0);
Expand Down
Loading