ci: add static analysis action

[finger563]

Description

• Add static_analysis action for performing static analysis of the code when making changes
• Update code to fix any issues found by static analysis
• Removed state_machine/include/magic_enum.hpp and replaced with external/magic_enum submodule (which is included by the state_machine component)
• Fixed bug in led class related to semaphore access / management (found by SA)

Motivation and Context

Helps ensure code quality by checking mistakes or bad programming practices. Also helps with code consistency.

How has this been tested?

Building the examples in this PR and checking that the static analysis PR action runs and produces meaningful output.

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation Update
• Hardware (schematic, board, system design) change
• Software change

Checklist:

• My change requires a change to the documentation.
• I have added / updated the documentation related to this change via either README or WIKI

Software

• I have added tests to cover my changes.
• I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
• All new and existing tests passed.
• My code follows the code style of this project.

[github-actions]

⚡ Static analysis result ⚡

🔴 cppcheck found 6 issues! Click here to see details.

espp/components/state_machine/include/magic_enum.hpp

Lines 863 to 868 in 2712283

	BinaryPredicate&& pred = {}) {
	using result_t = std::invoke_result_t<ResultGetterType>;
	using hash_t = std::conditional_t<no_duplicate<GlobValues, Hash>(), Hash, typename Hash::secondary_hash>;
	constexpr std::array _values = *GlobValues;
	constexpr std::size_t size = _values.size();
	constexpr std::array cases = calculate_cases<GlobValues, hash_t>(Page);

!Line: 863 - information: ValueFlow analysis is limited in constexpr_switch. Use --check-level=exhaustive if full analysis is wanted. [checkLevelNormal]

espp/components/state_machine/include/magic_enum.hpp

Lines 731 to 736 in 2712283

	crc = (crc >> 8) ^ crc_table[(crc ^ static_cast<std::uint32_t>(c)) & 0xff];
	}
	return crc ^ 0xffffffffL;
	}
	struct secondary_hash {

!Line: 731 - style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm]

espp/components/state_machine/include/magic_enum.hpp

Lines 741 to 746 in 2712283

	acc = ((acc ^ static_cast<std::uint64_t>(c)) * static_cast<std::uint64_t>(16777619ULL)) & (std::numeric_limits<std::uint32_t>::max)();
	}
	return static_cast<std::uint32_t>(acc);
	}
	};
	};

!Line: 741 - style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm]

espp/components/state_machine/include/magic_enum.hpp

Lines 255 to 260 in 2712283

	[[maybe_unused]] static constexpr char to_lower(char c) noexcept {
	return (c >= 'A' && c <= 'Z') ? static_cast<char>(c + ('a' - 'A')) : c;
	}
	public:
	template <typename L, typename R>

!Line: 255 - style: Unused private function: 'case_insensitive::to_lower' [unusedPrivateFunction]

espp/components/state_machine/include/magic_enum.hpp

Lines 730 to 735 in 2712283

	for (const auto c : value) {
	crc = (crc >> 8) ^ crc_table[(crc ^ static_cast<std::uint32_t>(c)) & 0xff];
	}
	return crc ^ 0xffffffffL;
	}

!Line: 730 - information: Unmatched suppression: useStlAlgorithm [unmatchedSuppression]

espp/components/state_machine/include/magic_enum.hpp

Lines 740 to 745 in 2712283

	for (const auto c : value) {
	acc = ((acc ^ static_cast<std::uint64_t>(c)) * static_cast<std::uint64_t>(16777619ULL)) & (std::numeric_limits<std::uint32_t>::max)();
	}
	return static_cast<std::uint32_t>(acc);
	}
	};

!Line: 740 - information: Unmatched suppression: useStlAlgorithm [unmatchedSuppression]

---