-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(base_component): add new base component and improve I2C class + example #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add base component which contains logger with some methods for setting logging level and tag for the logger * Update i2c to subclass base component and add some extra methods for writing / reading with std::vector. Also added some logging to the i2c component * Add i2c format helpers for logging the i2c bus which is initialized * Add missing i2c destructor * Update i2c example to test new i2c destructor * Add i2c menu to i2c example for allowing interactive control / query of the i2c bus using cli component * Update i2c and cli component to have s3 defualts file configuring the console output port to be usb serial/jtag
✅Static analysis result - no issues found! ✅ |
…ed peripheral code still compiles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
espp::BaseComponent
adc
bldc_driver
bldc_haptics
bldc_motor
button
controller
display
encoder
event_manager
file_system
ftp
i2c
input_drivers
joystick
led
led_strip
monitor
pid
rmt
rtsp
socket
task
thermistor
timer
wifi
Motivation and Context
A base component reduces boilerplate by adding logger and some log related functions to the base class.
How has this been tested?
task
exampleadc
exampleScreenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):
Types of changes
Checklist:
Software
.github/workflows/build.yml
file to add my new test to the automated cloud build github action.