lcd: fix incompatible feature #244
Conversation
|
@tore-espressif @espzav PTAL, thank you! |
Lzw655
force-pushed
the
bugfix/fix_lcd_incompatible_feature
branch
from
5e4e362 to
41ec602
Compare
Lzw655
force-pushed
the
bugfix/fix_lcd_incompatible_feature
branch
from
41ec602 to
f2e2d73
Compare
| .quadhd_io_num = -1, \ | ||
| .quadwp_io_num = -1, \ | ||
| .max_transfer_sz = SPI_LL_DMA_MAX_BIT_LEN >> 3, \ | ||
| #define GC9A01_PANEL_BUS_SPI_CONFIG(sclk, mosi, max_trans_sz) \ |
There was a problem hiding this comment.
Oh, I thought it didn't need to be changed since the 1.1.0 version has been marked yanked.
There was a problem hiding this comment.
@igrr Can we remove the 1.1.0 version from the ESP Registry?
There was a problem hiding this comment.
@tore-espressif Could you please help with this?
There was a problem hiding this comment.
I thought it didn't need to be changed since the 1.1.0 version has been marked yanked.
Breaking changes are allowed only between major releases, eg. 1.1.0 -> 2.0.0.
Can we remove the 1.1.0 version from the ESP Registry?
1.1.0 was yanked. We want to avoid deleting broken versions, to keep sync between git and component-registry.
@Lzw655 Ideally, you can push a fix that would garantuee compatibility -> 1.2.1. Or we can re-release this as 2.0.0
There was a problem hiding this comment.
I thought it didn't need to be changed since the 1.1.0 version has been marked yanked.
Breaking changes are allowed only between major releases, eg. 1.1.0 -> 2.0.0.
Can we remove the 1.1.0 version from the ESP Registry?
1.1.0 was yanked. We want to avoid deleting broken versions, to keep sync between git and component-registry.
@Lzw655 Ideally, you can push a fix that would garantuee compatibility -> 1.2.1. Or we can re-release this as 2.0.0
Ok, I will submit a PR to bump their versions to 2.0.0.
ESP-BSP Pull Request checklist
Change description
rgb_ele_orderwithrgb_endian