Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cdc_and_usb_device): Split the tests for cdc and disconnection verification (part1/2) #108

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

roma-jam
Copy link
Collaborator

@roma-jam roma-jam commented Jan 2, 2025

Description

Split the test application for cdc and disconnection verification.

Part1/2: Curved out the disconnection test in a standalone test_app (to work on P4 requires usb phy changes to configure the IOs)

Related

Limitations

  • Disconnection test is not enabled as it is not working on P4 yet.

Testing

N/A


Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@roma-jam roma-jam force-pushed the feature/dconn_detection_test branch from 43a535c to ebe0ac0 Compare January 2, 2025 11:29
@roma-jam roma-jam self-assigned this Jan 2, 2025
Base automatically changed from feature/esp_tinyusb_stack_teardown to master January 2, 2025 15:57
@roma-jam roma-jam force-pushed the feature/dconn_detection_test branch 2 times, most recently from 898c672 to 8488ae7 Compare January 6, 2025 08:55
@roma-jam roma-jam changed the title refactor(cdc_and_usb_device): Split the tests for cdc and disconnection verification refactor(cdc_and_usb_device): Split the tests for cdc and disconnection verification (part1/2) Jan 6, 2025
@roma-jam roma-jam added this to the esp_tinyusb v1.7.0 milestone Jan 6, 2025
@roma-jam roma-jam marked this pull request as ready for review January 6, 2025 11:31
@roma-jam
Copy link
Collaborator Author

roma-jam commented Jan 6, 2025

@tore-espressif @peter-marcisovsky
When I added the disconnection test in the past, I did it to the cdc test.
In this PR, I split them for two independent test_apps and curved out the configuration test completely.
So, this PR is just splitting the test_apps for cdc and verifying bvalid signal routing.
The PR with reverted the configuration verification is here (goes as part 2): #111

@roma-jam roma-jam force-pushed the feature/dconn_detection_test branch from 0726ee3 to db62192 Compare January 6, 2025 12:19
@roma-jam roma-jam force-pushed the feature/dconn_detection_test branch from db62192 to a0bec58 Compare January 6, 2025 12:37
Copy link
Collaborator

@peter-marcisovsky peter-marcisovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for the update. LGTM.

Copy link
Collaborator

@tore-espressif tore-espressif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roma-jam roma-jam merged commit d8041fd into master Jan 7, 2025
31 checks passed
@roma-jam roma-jam deleted the feature/dconn_detection_test branch January 7, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants