Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

weETH withdrawal: Instant withdrawal with Fee + Implicit withdrawal fee handling #207

Open
wants to merge 99 commits into
base: master
Choose a base branch
from
Open

weETH withdrawal: Instant withdrawal with Fee + Implicit withdrawal fee handling #207

wants to merge 99 commits into from

Conversation

seongyun-ko
Copy link
Contributor

@seongyun-ko seongyun-ko commented Dec 9, 2024 •
edited
Loading

Features

  1. Instant Withdrawal with Fee

    • Contract: EtherFiWithdrawalBuffer
    • (1) rate limits, (2) low-water mark mechanism, (3) fee & split configuration

  2. Handling of the unburned shares during the delayed withdrawal

    • Contract: WithdrawRequestNFT
    • the existing delayed withdrawal system had a bug in tracking the dust share amount.
    • This PR (1) fixes the bug, (2) adds the function to handle the accumulated dust, and (3) adds the fee split logic

Audited by Certora

@seongyun-ko seongyun-ko requested a review from jtfirek December 9, 2024 08:41
jtfirek
jtfirek reviewed Dec 19, 2024
View reviewed changes
src/WithdrawRequestNFT.sol Outdated Show resolved Hide resolved
jtfirek
jtfirek reviewed Dec 19, 2024
View reviewed changes
src/WithdrawRequestNFT.sol Outdated Show resolved Hide resolved
@seongyun-ko seongyun-ko changed the title Addition of Instant Withdrawal with Fee + handling of unburnt shares from delayed withdrawals Instant Withdrawal with Fee + handling of unburnt shares from delayed withdrawals Dec 20, 2024
@seongyun-ko seongyun-ko force-pushed the syko/feature/instant_withdrawal branch from 1dbd966 to a3aeac9 Compare December 20, 2024 01:31
shivam-ef
shivam-ef approved these changes Dec 23, 2024
View reviewed changes
Copy link

@shivam-ef shivam-ef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/WithdrawRequestNFT.sol Outdated Show resolved Hide resolved
@seongyun-ko seongyun-ko changed the title Instant Withdrawal with Fee + handling of unburnt shares from delayed withdrawals weETH withdrawal: Instant withdrawal with Fee + Implicit withdrawal fee handling Dec 30, 2024
seongyun-ko and others added 30 commits January 21, 2025 10:55
@seongyun-ko @shivam-ef
only owner of the funds can call {redeemEEth, redeemWeEth}
f36c180
@seongyun-ko @shivam-ef
disable unpause until the scan is completed
3356771
@seongyun-ko @shivam-ef
check the basis points params are below 1e4
ddd1b59
@seongyun-ko @shivam-ef
disallow calling 'initializeOnUpgradeWithRedemptionManager' with inva…
43a5a5e 
…lid param & calling it twice
@seongyun-ko @shivam-ef
(1) withdrawRequestNFT cannot call LiquidityPool.addEthAmountLockedFo…
aa53280 
…rWithdrawal, (2) remove unused function reduceEthAmountLockedForWithdrawal
@seongyun-ko @shivam-ef
prevent finalizing future requests
8ae4844
@seongyun-ko @shivam-ef
add {redeemEEthWithPermit, redeemWeEthWithPermit}, use try-catch for
26b5a0b
@seongyun-ko @shivam-ef
remove a redundant check
a785f25
@seongyun-ko @shivam-ef
Prevent 'initializeOnUpgrade' of LiquidityPool from being called twic…
8785224 
…e, add the unused gap var and add initialization for added variables
@seongyun-ko @shivam-ef
use 'isScanOfShareRemainderCompleted'
edc30cb
@seongyun-ko @shivam-ef
add the max value constraint on rate limit
b666808
@seongyun-ko @shivam-ef
remove equality condition
23fd48b
@seongyun-ko @shivam-ef
fix the overflow issue in '_refill'
7a909ac 
Signed-off-by: syko <[email protected]>
@seongyun-ko @shivam-ef
Update EtherFiRedemptionManager.sol
0e6662b 
Signed-off-by: syko <[email protected]>
@seongyun-ko @shivam-ef
prevent the total shares from going below 1 gwei after redemption
f2cbc82 
Signed-off-by: syko <[email protected]>
@shivam-ef
fixes for Instant Withdrawal
d193b00
@shivam-ef
fix: certora audit fixes
17aabaa
@shivam-ef
changed gas limit in redemption to 50k from 10k
c782ab3
@shivam-ef
added only liquidity pool to burn shares
b877f7e
@shivam-ef
remove batch cancel deposit by admin since not required
3128cf3
@shivam-ef
Merge branch 'syko/feature/instant_withdrawal' of https://github.com/…
fdbf21a 
…etherfi-protocol/smart-contracts into shivam/fix/instant_withdrawal
@shivam-ef
Merge branch 'master' of https://github.com/etherfi-protocol/smart-co…
1cb9971 
…ntracts into syko/feature/instant_withdrawal
@shivam-ef
Merge branch 'syko/feature/instant_withdrawal' of https://github.com/…
fd0f75f 
…etherfi-protocol/smart-contracts into shivam/fix/instant_withdrawal
@shivam-ef
removed duplicate bytecode_hash config from foundry.toml and added au…
ce827c2 
…dit report
@shivam-ef
instant withdrawal upgrade prepared
3230fa7
@shivam-ef
instant withdrawal script
07bbcfa
@shivam-ef
deployed instant withdrawal upgrade
3b4be39
@shivam-ef
fix test
c2e6a53
@seongyun-ko
Rename 2025.01.23 - Certora - EtherFi - Withdrawal Fee - Re-audit.pdf…
95cfaaa 
… to 2025.01.23 - Certora - EtherFi - Withdrawal Fee.pdf

Signed-off-by: syko <[email protected]>
@shivam-ef
Merge pull request #227 from etherfi-protocol/shivam/fix/instant_with…
824bcf8 
…drawal

fixes for Instant Withdrawal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shivam-ef shivam-ef shivam-ef approved these changes

@jtfirek jtfirek jtfirek approved these changes

@vvalecha519 vvalecha519 Awaiting requested review from vvalecha519

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seongyun-ko @jtfirek @shivam-ef