weETH withdrawal: Instant withdrawal with Fee + Implicit withdrawal fee handling#207

Open

seongyun-ko wants to merge 99 commits intomasterfrom syko/feature/instant_withdrawal

+1,553-172

Commits on Dec 6, 2024

init. Instant Withdrawal via Buffer
seongyun-ko
committed

Commits on Dec 9, 2024

implemented instant fee mechanism, handling of the implicit fee
seongyun-ko
committed

Commits on Dec 12, 2024

fix scripts
seongyun-ko
committed

Commits on Dec 17, 2024

add role registry, consider eth amount locked for withdrawal in liquidity pool, add tests
seongyun-ko
committed

Commits on Dec 19, 2024

use setter for 'shareRemainderSplitToTreasuryInBps', add more fuzz tests, add deploy script
seongyun-ko
committed

Commits on Dec 20, 2024

Commits on Dec 24, 2024

Commits on Dec 26, 2024

Certora audit: (1) add {aggregateSumEEthShareAmount}, (2) fix {_claimWithdraw} to account with 'totalLockedEEthShares', (3) simplify 'seizeRequest', (4) handle some issues
seongyun-ko
committed

Commits on Dec 30, 2024

Commits on Jan 1, 2025

(1) pause the contract on upgrade, (2) prevent from calling 'aggregateSumEEthShareAmount' again after the scan is completed, (3) prevent from undoing the finalization 'finalizeRequests'
seongyun-ko
committed

Commits on Jan 2, 2025

Commits on Jan 21, 2025

init. Instant Withdrawal via Buffer

seongyun-ko
authored and
shivam-ef
committed
implemented instant fee mechanism, handling of the implicit fee

seongyun-ko
authored and
shivam-ef
committed
fix scripts

seongyun-ko
authored and
shivam-ef
committed
add role registry, consider eth amount locked for withdrawal in liquidity pool, add tests

seongyun-ko
authored and
shivam-ef
committed
use setter for 'shareRemainderSplitToTreasuryInBps', add more fuzz tests, add deploy script

seongyun-ko
authored and
shivam-ef
committed
handle issues in calculating the dust shares

seongyun-ko
authored and
shivam-ef
committed
improve comments

seongyun-ko
authored and
shivam-ef
committed
add sorted & unique constraints + type change to reduce gas

seongyun-ko
authored and
shivam-ef
committed
update 'handleAccumulatedShareRemainder' to be callable by admin

seongyun-ko
authored and
shivam-ef
committed
Certora audit: (1) add {aggregateSumEEthShareAmount}, (2) fix {_claimWithdraw} to account with 'totalLockedEEthShares', (3) simplify 'seizeRequest', (4) handle some issues

seongyun-ko
authored and
shivam-ef
committed
wip: to be amended

seongyun-ko
authored and
shivam-ef
committed
add simplified {invalidate, validate} request, fix unit tests

seongyun-ko
authored and
shivam-ef
committed
rename EtherFiWithdrawBuffer -> EtherFiRedemptionManager

seongyun-ko
authored and
shivam-ef
committed
fix the logic to check the aggr calls

seongyun-ko
authored and
shivam-ef
committed
Update test/WithdrawRequestNFT.t.sol

jtfirek
authored and
shivam-ef
committed
reduce gas spending for 'call', update the upgrade init function, remove unused file

seongyun-ko
authored and
shivam-ef
committed
apply gas opt for BucketLimiter

seongyun-ko
authored and
shivam-ef
committed
improve assetion tsets, apply design pattern, function rename

seongyun-ko
authored and
shivam-ef
committed
apply CEI pattern to 'handleRemainder'

seongyun-ko
authored and
shivam-ef
committed
apply CEI pattern to 'redeem'

seongyun-ko
authored and
shivam-ef
committed
use 'totalRemainderEEthShares' instead of locked share

seongyun-ko
authored and
shivam-ef
committed
initializeOnUpgrade cant be called twice

seongyun-ko
authored and
shivam-ef
committed
initializeOnUpgrade onlyOnce

seongyun-ko
authored and
shivam-ef
committed
use uint256 instead of uint32

seongyun-ko
authored and
shivam-ef
committed
revert

seongyun-ko
authored and
shivam-ef
committed
improve the fuzz test

seongyun-ko
authored and
shivam-ef
committed
(1) pause the contract on upgrade, (2) prevent from calling 'aggregateSumEEthShareAmount' again after the scan is completed, (3) prevent from undoing the finalization 'finalizeRequests'

seongyun-ko
authored and
shivam-ef
committed
only owner of the funds can call {redeemEEth, redeemWeEth}

seongyun-ko
authored and
shivam-ef
committed
disable unpause until the scan is completed

seongyun-ko
authored and
shivam-ef
committed
check the basis points params are below 1e4

seongyun-ko
authored and
shivam-ef
committed
disallow calling 'initializeOnUpgradeWithRedemptionManager' with invalid param & calling it twice

seongyun-ko
authored and
shivam-ef
committed
(1) withdrawRequestNFT cannot call LiquidityPool.addEthAmountLockedForWithdrawal, (2) remove unused function reduceEthAmountLockedForWithdrawal

seongyun-ko
authored and
shivam-ef
committed
prevent finalizing future requests

seongyun-ko
authored and
shivam-ef
committed
add {redeemEEthWithPermit, redeemWeEthWithPermit}, use try-catch for

seongyun-ko
authored and
shivam-ef
committed
remove a redundant check

seongyun-ko
authored and
shivam-ef
committed
Prevent 'initializeOnUpgrade' of LiquidityPool from being called twice, add the unused gap var and add initialization for added variables

seongyun-ko
authored and
shivam-ef
committed
use 'isScanOfShareRemainderCompleted'

seongyun-ko
authored and
shivam-ef
committed
add the max value constraint on rate limit

seongyun-ko
authored and
shivam-ef
committed
remove equality condition

seongyun-ko
authored and
shivam-ef
committed
fix the overflow issue in '_refill'

seongyun-ko
authored and
shivam-ef
committed
Update EtherFiRedemptionManager.sol

seongyun-ko
authored and
shivam-ef
committed
prevent the total shares from going below 1 gwei after redemption

seongyun-ko
authored and
shivam-ef
committed
fixes for Instant Withdrawal
shivam-ef
committed
fix: certora audit fixes
shivam-ef
committed
changed gas limit in redemption to 50k from 10k
shivam-ef
committed
added only liquidity pool to burn shares
shivam-ef
committed
remove batch cancel deposit by admin since not required
shivam-ef
committed
Merge branch 'syko/feature/instant_withdrawal' of https://github.com/etherfi-protocol/smart-contracts into shivam/fix/instant_withdrawal
shivam-ef
committed

Commits on Jan 22, 2025

Commits on Jan 23, 2025

removed duplicate bytecode_hash config from foundry.toml and added audit report
shivam-ef
committed

Commits on Jan 24, 2025

instant withdrawal upgrade prepared
shivam-ef
committed

Commits on Jan 28, 2025

Commits on Feb 6, 2025

Rename 2025.01.23 - Certora - EtherFi - Withdrawal Fee - Re-audit.pdf to 2025.01.23 - Certora - EtherFi - Withdrawal Fee.pdf
seongyun-ko
authored

Commits on Feb 10, 2025

Merge pull request #227 from etherfi-protocol/shivam/fix/instant_withdrawal
shivam-ef
authored