Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration #32

Merged
merged 169 commits into from
Apr 28, 2020
Merged

Integration #32

merged 169 commits into from
Apr 28, 2020

Conversation

fjulian
Copy link
Member

@fjulian fjulian commented Jan 20, 2020

Let's get this branch into a mergable state, before it grows out of control...

After this, we can look into making this run on Panda as well.

@fjulian
Copy link
Member Author

fjulian commented Jan 28, 2020

How would y'all feel if we renamed the moma_demos directory to simply demos?

TBH, I like that the part before the _ gives away what arm/base combination this applies to. But then, no robot name before the _ could also just imply "moma", i.e. any arm on any base. So I can live with either option.

Copy link
Contributor

@mbreyer mbreyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mbreyer mbreyer merged commit db9acb6 into master Apr 28, 2020
@mbreyer mbreyer deleted the integration branch April 28, 2020 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants