Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multipart copy requires upload id, part number, and source range #217

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

geofflane
Copy link
Contributor

Trying to revive #106, which seemed to have gone dormant. The current implementation of upload_part_copy does not seem to work at all, and this fixes it.

This is a slightly different take. Like S3.upload_part, the upload_id, the part number, and the range are required attributes and shouldn't be put into opts, but part of the explicit API. Other than that, I copied the code mostly verbatim from #106 and just ensured it merged cleanly.

@geofflane
Copy link
Contributor Author

This should fix #75 as well I believe.

@bernardd
Copy link
Contributor

Hi @geofflane - thanks very much for the PR and apologies for taking so long to get to it. All looks good to me - usually I'd be concerned about changing the signature of an API function like this but looking at the docs, it really looks like you're absolutely right that there's no possible way it could have worked in its current form, so I've gotta assume nobody's using it :)

@bernardd bernardd merged commit 6d497a4 into ex-aws:main Sep 25, 2023
This was referenced Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants